From patchwork Fri Jan 9 20:17:09 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 1619 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n09KEQws012924 for ; Fri, 9 Jan 2009 12:14:26 -0800 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754664AbZAIUSJ (ORCPT ); Fri, 9 Jan 2009 15:18:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754505AbZAIUSI (ORCPT ); Fri, 9 Jan 2009 15:18:08 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:35092 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753415AbZAIUSG (ORCPT ); Fri, 9 Jan 2009 15:18:06 -0500 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n09KH9Er021365 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 9 Jan 2009 12:17:10 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n09KH9OP014905; Fri, 9 Jan 2009 12:17:09 -0800 Message-Id: <200901092017.n09KH9OP014905@imap1.linux-foundation.org> Subject: [patch 2/6] acpi: check _PSS invalidation when BIOS report _PSS with 0x80000000 To: lenb@kernel.org Cc: linux-acpi@vger.kernel.org, akpm@linux-foundation.org, youquan.song@intel.com, venkatesh.pallipadi@intel.com From: akpm@linux-foundation.org Date: Fri, 09 Jan 2009 12:17:09 -0800 X-Spam-Status: No, hits=-3.411 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Youquan, Song When cpu frequencey scaling is disabled, some BIOSes report _PSS with all 0x80000000. If the kernel treats this case as valid, the kernel will boot crash when load cpufreq govenors. So in order to cover more buggy BIOSs, the patch just check _PSS core frequency invalidation. Signed-off-by: Youquan, Song Signed-off-by: Pallipadi, Venkatesh Cc: Len Brown Signed-off-by: Andrew Morton --- drivers/acpi/processor_perflib.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff -puN drivers/acpi/processor_perflib.c~acpi-check-_pss-invalidation-when-bios-report-_pss-with-all-0x80000000 drivers/acpi/processor_perflib.c --- a/drivers/acpi/processor_perflib.c~acpi-check-_pss-invalidation-when-bios-report-_pss-with-all-0x80000000 +++ a/drivers/acpi/processor_perflib.c @@ -50,6 +50,7 @@ #define ACPI_PROCESSOR_CLASS "processor" #define ACPI_PROCESSOR_FILE_PERFORMANCE "performance" #define _COMPONENT ACPI_PROCESSOR_COMPONENT +#define ACPI_PROCESSOR_PSS_INVALID 0x80000000 ACPI_MODULE_NAME("processor_perflib"); static DEFINE_MUTEX(performance_mutex); @@ -324,6 +325,14 @@ static int acpi_processor_get_performanc kfree(pr->performance->states); goto end; } + + if (px->core_frequency == ACPI_PROCESSOR_PSS_INVALID) { + printk(KERN_ERR PREFIX + "P-states disabled in the BIOS\n"); + result = -EFAULT; + kfree(pr->performance->states); + goto end; + } } end: