From patchwork Sun Jan 11 13:52:37 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ingo Molnar X-Patchwork-Id: 1775 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n0BDoBaP014900 for ; Sun, 11 Jan 2009 05:50:13 -0800 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754323AbZAKNxn (ORCPT ); Sun, 11 Jan 2009 08:53:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754007AbZAKNxn (ORCPT ); Sun, 11 Jan 2009 08:53:43 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:42426 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752949AbZAKNxk (ORCPT ); Sun, 11 Jan 2009 08:53:40 -0500 Received: from elvis.elte.hu ([157.181.1.14]) by mx3.mail.elte.hu with esmtp (Exim) id 1LM0k3-0006bb-UX from ; Sun, 11 Jan 2009 14:52:46 +0100 Received: by elvis.elte.hu (Postfix, from userid 1004) id DBC1A3E21AA; Sun, 11 Jan 2009 14:52:37 +0100 (CET) Date: Sun, 11 Jan 2009 14:52:37 +0100 From: Ingo Molnar To: Jaswinder Singh Rajput Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Adrian Bunk , Andrew Morton , Linus Torvalds , Natalie Protasevich , Kernel Testers List , Network Development , Linux ACPI , Linux PM List , Linux SCSI List Subject: Re: 2.6.29-rc1: Reported regressions from 2.6.28 Message-ID: <20090111135237.GA20184@elte.hu> References: <3f9a31f40901110546h4c069b5dx9726a0fbf8caf5a1@mail.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3f9a31f40901110546h4c069b5dx9726a0fbf8caf5a1@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Received-SPF: neutral (mx3: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu; X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org * Jaswinder Singh Rajput wrote: > On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki wrote: > > > > Regressions with patches > > ------------------------ > > > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12428 > > Subject : Build error on latest git > > Submitter : Petr Titera > > Date : 2009-01-11 9:49 (1 days old) > > References : http://marc.info/?l=linux-kernel&m=123166856318712&w=4 > > Handled-By : Petr Titera > > Patch : http://marc.info/?l=linux-kernel&m=123167509024996&w=4 > > This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP > is defined. > > I am still in the process of cleaning non-smp data from asm/smp.h for > x86 > > Attach patch is the solution for the time being > > Ingo, can you please put this in urgent queue. yes, it already is - see below. Ingo -----------------> From 8b5a33599c541cf5bf66304343d08ff2795d038b Mon Sep 17 00:00:00 2001 From: Jaswinder Singh Rajput Date: Sun, 11 Jan 2009 18:38:55 +0530 Subject: [PATCH] x86: fix mpparse.c build error on latest git Fix this by reintroducing asm/smp.h include in mpparse.c - later on I will fix this by removing non-smp data from smp.h. Reported-by: Petr Titera Signed-off-by: Jaswinder Singh Rajput Signed-off-by: Ingo Molnar --- arch/x86/kernel/mpparse.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c index c0601c2..a649a4c 100644 --- a/arch/x86/kernel/mpparse.c +++ b/arch/x86/kernel/mpparse.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #ifdef CONFIG_X86_32