| Message ID | 200903041955.n24JtOKb027987@imap1.linux-foundation.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
applied to oqo-wmi-EXPECT-REFRESH branch expecting a revised patch from Matthew at some point... thanks -- Len Brown, Intel Open Source Technology Center On Wed, 4 Mar 2009, akpm@linux-foundation.org wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > oqo driver uses polled input functions, so make it depend > on INPUT_POLLDEV. > > ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined! > ERROR: "input_allocate_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined! > ERROR: "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined! > ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined! > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Cc: Matthew Garrett <mjg59@srcf.ucam.org> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: Len Brown <lenb@kernel.org> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > --- > > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev drivers/platform/x86/Kconfig > --- a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev > +++ a/drivers/platform/x86/Kconfig > @@ -137,7 +137,7 @@ config MSI_LAPTOP > config OQO_WMI > tristate "OQO WMI extras" > depends on ACPI_WMI > - depends on INPUT > + depends on INPUT && INPUT_POLLDEV > depends on RFKILL > depends on BACKLIGHT_CLASS_DEVICE > help > _ > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 04 March 2009 11:55:24 akpm@linux-foundation.org wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > oqo driver uses polled input functions, so make it depend > on INPUT_POLLDEV. > > ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] > undefined! ERROR: "input_allocate_polled_device" > [drivers/platform/x86/oqo-wmi.ko] undefined! ERROR: > "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined! > ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] > undefined! > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Cc: Matthew Garrett <mjg59@srcf.ucam.org> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: Len Brown <lenb@kernel.org> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > --- > > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev > drivers/platform/x86/Kconfig --- > a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++ > a/drivers/platform/x86/Kconfig > @@ -137,7 +137,7 @@ config MSI_LAPTOP > config OQO_WMI > tristate "OQO WMI extras" > depends on ACPI_WMI > - depends on INPUT > + depends on INPUT && INPUT_POLLDEV Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users should not have to select it for some drivers to become available.
Dmitry Torokhov wrote: > On Wednesday 04 March 2009 11:55:24 akpm@linux-foundation.org wrote: >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> oqo driver uses polled input functions, so make it depend >> on INPUT_POLLDEV. >> >> ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] >> undefined! ERROR: "input_allocate_polled_device" >> [drivers/platform/x86/oqo-wmi.ko] undefined! ERROR: >> "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined! >> ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] >> undefined! >> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >> Cc: Matthew Garrett <mjg59@srcf.ucam.org> >> Cc: Ingo Molnar <mingo@elte.hu> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: "H. Peter Anvin" <hpa@zytor.com> >> Cc: Len Brown <lenb@kernel.org> >> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> >> --- >> >> drivers/platform/x86/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev >> drivers/platform/x86/Kconfig --- >> a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++ >> a/drivers/platform/x86/Kconfig >> @@ -137,7 +137,7 @@ config MSI_LAPTOP >> config OQO_WMI >> tristate "OQO WMI extras" >> depends on ACPI_WMI >> - depends on INPUT >> + depends on INPUT && INPUT_POLLDEV > > Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users > should not have to select it for some drivers to become available. Did the OQO_WMI stuff go away? I can't seem to find it anywhere.
> >> > >> drivers/platform/x86/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev > >> drivers/platform/x86/Kconfig --- > >> a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++ > >> a/drivers/platform/x86/Kconfig > >> @@ -137,7 +137,7 @@ config MSI_LAPTOP > >> config OQO_WMI > >> tristate "OQO WMI extras" > >> depends on ACPI_WMI > >> - depends on INPUT > >> + depends on INPUT && INPUT_POLLDEV > > > > Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users > > should not have to select it for some drivers to become available. > > > Did the OQO_WMI stuff go away? I can't seem to find it anywhere. yeah, i droppped it from my test tree while distracted with the 2.6.30 merge. it is back now. -Len Brown, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev drivers/platform/x86/Kconfig --- a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++ a/drivers/platform/x86/Kconfig @@ -137,7 +137,7 @@ config MSI_LAPTOP config OQO_WMI tristate "OQO WMI extras" depends on ACPI_WMI - depends on INPUT + depends on INPUT && INPUT_POLLDEV depends on RFKILL depends on BACKLIGHT_CLASS_DEVICE help