diff mbox

[7/8] acpi: check for pxm_to_node_map overflow

Message ID 200903041955.n24JtUTS028013@imap1.linux-foundation.org (mailing list archive)
State Accepted
Headers show

Commit Message

Andrew Morton March 4, 2009, 7:55 p.m. UTC 
From: Cyrill Gorcunov <gorcunov@gmail.com>

It is hardly (if ever) possible but in case of broken _PXM entry we could
reach out of pxm_to_node_map array bounds in acpi_map_pxm_to_node() call.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/acpi/numa.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Len Brown March 16, 2009, 3:47 a.m. UTC | #1 
applied

thanks,
Len Brown, Intel Open Source Technology Center

On Wed, 4 Mar 2009, akpm@linux-foundation.org wrote:

> From: Cyrill Gorcunov <gorcunov@gmail.com>
> 
> It is hardly (if ever) possible but in case of broken _PXM entry we could
> reach out of pxm_to_node_map array bounds in acpi_map_pxm_to_node() call.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/acpi/numa.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/acpi/numa.c~acpi-check-for-pxm_to_node_map-overflow drivers/acpi/numa.c
> --- a/drivers/acpi/numa.c~acpi-check-for-pxm_to_node_map-overflow
> +++ a/drivers/acpi/numa.c
> @@ -277,7 +277,7 @@ int acpi_get_node(acpi_handle *handle)
>  	int pxm, node = -1;
>  
>  	pxm = acpi_get_pxm(handle);
> -	if (pxm >= 0)
> +	if (pxm >= 0 && pxm < MAX_PXM_DOMAINS)
>  		node = acpi_map_pxm_to_node(pxm);
>  
>  	return node;
> _
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -puN drivers/acpi/numa.c~acpi-check-for-pxm_to_node_map-overflow drivers/acpi/numa.c
--- a/drivers/acpi/numa.c~acpi-check-for-pxm_to_node_map-overflow
+++ a/drivers/acpi/numa.c
@@ -277,7 +277,7 @@  int acpi_get_node(acpi_handle *handle)
 	int pxm, node = -1;
 
 	pxm = acpi_get_pxm(handle);
-	if (pxm >= 0)
+	if (pxm >= 0 && pxm < MAX_PXM_DOMAINS)
 		node = acpi_map_pxm_to_node(pxm);
 
 	return node;