From patchwork Wed Mar 4 19:55:30 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 9906 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n24JuAr3023685 for ; Wed, 4 Mar 2009 19:56:12 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756135AbZCDT4M (ORCPT ); Wed, 4 Mar 2009 14:56:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756207AbZCDT4M (ORCPT ); Wed, 4 Mar 2009 14:56:12 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:59956 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756160AbZCDT4K (ORCPT ); Wed, 4 Mar 2009 14:56:10 -0500 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n24JtVvs010560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 4 Mar 2009 11:55:32 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n24JtUd9028016; Wed, 4 Mar 2009 11:55:30 -0800 Message-Id: <200903041955.n24JtUd9028016@imap1.linux-foundation.org> Subject: [patch 8/8] acpi: wmi.c: unsigned cannot be less than 0 To: lenb@kernel.org Cc: linux-acpi@vger.kernel.org, akpm@linux-foundation.org, roel.kluin@gmail.com From: akpm@linux-foundation.org Date: Wed, 04 Mar 2009 11:55:30 -0800 X-Spam-Status: No, hits=-3.453 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Roel Kluin include/linux/pci-acpi.h:74: typedef u32 acpi_status; result is unsigned, so an error returned by acpi_bus_register_driver() will not be noticed. Signed-off-by: Roel Kluin Cc: Len Brown Signed-off-by: Andrew Morton --- drivers/platform/x86/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/platform/x86/wmi.c~acpi-wmic-unsigned-cannot-be-less-than-0 drivers/platform/x86/wmi.c --- a/drivers/platform/x86/wmi.c~acpi-wmic-unsigned-cannot-be-less-than-0 +++ a/drivers/platform/x86/wmi.c @@ -708,7 +708,7 @@ static int __init acpi_wmi_add(struct ac static int __init acpi_wmi_init(void) { - acpi_status result; + int result; INIT_LIST_HEAD(&wmi_blocks.list);