From patchwork Thu Mar 5 10:25:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Renninger X-Patchwork-Id: 10006 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n25AQQJR015176 for ; Thu, 5 Mar 2009 10:26:26 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753445AbZCEKZw (ORCPT ); Thu, 5 Mar 2009 05:25:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752301AbZCEKZw (ORCPT ); Thu, 5 Mar 2009 05:25:52 -0500 Received: from mail.suse.de ([195.135.220.2]:41655 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755120AbZCEKZs (ORCPT ); Thu, 5 Mar 2009 05:25:48 -0500 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 9B4E945756; Thu, 5 Mar 2009 11:25:44 +0100 (CET) From: Thomas Renninger Organization: SUSE Products GmbH To: akpm@linux-foundation.org Subject: Re: [patch for 2.6.29? 1/1] acer-wmi: fix regression in backlight detection Date: Thu, 5 Mar 2009 11:25:40 +0100 User-Agent: KMail/1.10.3 (Linux/2.6.27.15-SLE11_BRANCH_20090211224354_e2f9ae3b-default; KDE/4.1.3; x86_64; ; ) Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, mspang@csclub.uwaterloo.ca, ak@linux.intel.com, carlos@strangeworlds.co.uk, len.brown@intel.com, rjw@sisk.pl, rui.zhang@intel.com, stable@kernel.org References: <200903042007.n24K7Yc7029496@imap1.linux-foundation.org> In-Reply-To: <200903042007.n24K7Yc7029496@imap1.linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200903051125.42313.trenn@suse.de> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On Wednesday 04 March 2009 21:07:34 akpm@linux-foundation.org wrote: > From: Michael Spang > > Currently we disable the Acer WMI backlight device if there is no ACPI > backlight device. As a result, we end up with no backlight device at all. > We should instead disable it if there is an ACPI device, as the other > laptop drivers do. This regression was introduced in febf2d9 ("Acer-WMI: > fingers off backlight if video.ko is serving this functionality"). > > Each laptop driver with backlight support got a similar change around > febf2d9. The changes to the other drivers look correct; see e.g. > a598c82f for a similar but correct change. The regression is also in > 2.6.28. Len, can you apply this one, please. > Signed-off-by: Michael Spang > Cc: Thomas Renninger Signed-off-by: Thomas Renninger No idea about stable policy, whether you have to wait for a mainline commit first or if you just push such typos. Here is the patch against 2.6.28, there the bug got introduced (file moved). Thanks, Thomas --- drivers/misc/acer-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/drivers/misc/acer-wmi.c =================================================================== --- linux-2.6.orig/drivers/misc/acer-wmi.c +++ linux-2.6/drivers/misc/acer-wmi.c @@ -1297,7 +1297,7 @@ static int __init acer_wmi_init(void) set_quirks(); - if (!acpi_video_backlight_support() && has_cap(ACER_CAP_BRIGHTNESS)) { + if (acpi_video_backlight_support() && has_cap(ACER_CAP_BRIGHTNESS)) { interface->capability &= ~ACER_CAP_BRIGHTNESS; printk(ACER_INFO "Brightness must be controlled by " "generic video driver\n");