why do drivers evaluate _INI?

Commit Message

Jonathan Woithe June 23, 2009, 12:28 a.m. UTC

Hi Tony

> On Mon, 2009-06-22 at 17:32 -0600, Bjorn Helgaas wrote:
> > I see the following drivers using _INI:
> >   drivers/platform/x86/fujitsu-laptop.c
> 
> Bjorn, can you send me an experimental patch where you remove it? I can
> regression test that for you on the Lifebook S6420.

As far as I can tell it's just a trivial removal of the relevent section of
the acpi_*_add() functions.  A patch doing this is at the end of this email.
This is completely untested so there may be something subtle I've missed
(for instance, the local "handle" variable is unused now I suspect but this
won't stop compilation or testing).

The patch is against fujitsu-laptop.c from 2.6.27.9 (the kernel source tree
I happen to have quick access to at present) but I don't *think* a lot has
changed since then so it should apply to other recent versions.

Regards
  jonathan

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- fujitsu-laptop.c-orig	2009-06-23 09:51:08.540087000 +0930
+++ fujitsu-laptop.c	2009-06-23 09:53:54.491830386 +0930
@@ -537,15 +537,6 @@  static int acpi_fujitsu_add(struct acpi_
 
 	fujitsu->dev = device;
 
-	if (ACPI_SUCCESS
-	    (acpi_get_handle(device->handle, METHOD_NAME__INI, &handle))) {
-		vdbg_printk(FUJLAPTOP_DBG_INFO, "Invoking _INI\n");
-		if (ACPI_FAILURE
-		    (acpi_evaluate_object
-		     (device->handle, METHOD_NAME__INI, NULL, NULL)))
-			printk(KERN_ERR "_INI Method failed\n");
-	}
-
 	/* do config (detect defaults) */
 	dmi_check_system(fujitsu_dmi_table);
 	use_alt_lcd_levels = use_alt_lcd_levels == 1 ? 1 : 0;
@@ -764,15 +755,6 @@  static int acpi_fujitsu_hotkey_add(struc
 
 	fujitsu_hotkey->dev = device;
 
-	if (ACPI_SUCCESS
-	    (acpi_get_handle(device->handle, METHOD_NAME__INI, &handle))) {
-		vdbg_printk(FUJLAPTOP_DBG_INFO, "Invoking _INI\n");
-		if (ACPI_FAILURE
-		    (acpi_evaluate_object
-		     (device->handle, METHOD_NAME__INI, NULL, NULL)))
-			printk(KERN_ERR "_INI Method failed\n");
-	}
-
 	i = 0;			/* Discard hotkey ringbuffer */
 	while (get_irb() != 0 && (i++) < MAX_HOTKEY_RINGBUFFER_SIZE) ;
 	vdbg_printk(FUJLAPTOP_DBG_INFO, "Discarded %i ringbuffer entries\n", i);