From patchwork Mon Aug 17 12:51:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frans Pop X-Patchwork-Id: 42032 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7HCpmu4019264 for ; Mon, 17 Aug 2009 12:51:48 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751630AbZHQMvp (ORCPT ); Mon, 17 Aug 2009 08:51:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751580AbZHQMvp (ORCPT ); Mon, 17 Aug 2009 08:51:45 -0400 Received: from cpsmtpm-eml105.kpnxchange.com ([195.121.3.9]:54656 "EHLO CPSMTPM-EML105.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbZHQMvo (ORCPT ); Mon, 17 Aug 2009 08:51:44 -0400 Received: from aragorn.fjphome.nl ([77.166.180.99]) by CPSMTPM-EML105.kpnxchange.com with Microsoft SMTPSVC(7.0.6001.18000); Mon, 17 Aug 2009 14:51:45 +0200 To: linux-acpi@vger.kernel.org Subject: [PATCH,resend] acpi processor: simplify needlessly complex printk Cc: linux-kernel@vger.kernel.org, Len Brown Content-Disposition: inline From: Frans Pop Date: Mon, 17 Aug 2009 14:51:43 +0200 MIME-Version: 1.0 Message-Id: <200908171451.44732.elendil@planet.nl> X-OriginalArrivalTime: 17 Aug 2009 12:51:45.0233 (UTC) FILETIME=[79E81410:01CA1F39] Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Why use three printk statements if one will do? Also makes it easier to grep for the string. Signed-off-by: Frans Pop --- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c index 84e0f3c..b8fb74a 100644 --- a/drivers/acpi/processor_core.c +++ b/drivers/acpi/processor_core.c @@ -772,12 +772,11 @@ static int __cpuinit acpi_processor_start(struct acpi_device *device) if (result) printk(KERN_ERR PREFIX "Create sysfs link\n"); - if (pr->flags.throttling) { - printk(KERN_INFO PREFIX "%s [%s] (supports", - acpi_device_name(device), acpi_device_bid(device)); - printk(" %d throttling states", pr->throttling.state_count); - printk(")\n"); - } + if (pr->flags.throttling) + printk(KERN_INFO PREFIX + "%s [%s] (supports %d throttling states)\n", + acpi_device_name(device), acpi_device_bid(device), + pr->throttling.state_count); end: