From patchwork Sun Aug 30 13:46:22 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 44754 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7UDkPST016041 for ; Sun, 30 Aug 2009 13:46:25 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753392AbZH3NqV (ORCPT ); Sun, 30 Aug 2009 09:46:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753463AbZH3NqV (ORCPT ); Sun, 30 Aug 2009 09:46:21 -0400 Received: from cantor.suse.de ([195.135.220.2]:54707 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753392AbZH3NqV (ORCPT ); Sun, 30 Aug 2009 09:46:21 -0400 Received: from relay1.suse.de (relay-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 4C1518E8CC; Sun, 30 Aug 2009 15:46:23 +0200 (CEST) From: Jean Delvare Organization: SuSE Linux To: linux-acpi@vger.kernel.org Subject: [PATCH] ACPI: Clarify resource conflict message Date: Sun, 30 Aug 2009 15:46:22 +0200 User-Agent: KMail/1.9.6 (enterprise 20070904.708012) Cc: Zhang Rui , Len Brown , Thomas Renninger MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200908301546.22827.jdelvare@suse.de> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org The message "ACPI: Device needs an ACPI driver" is misleading. The device _may_ need an ACPI driver, if the BIOS implemented an API for the device in question (which, AFAIK, can't be checked.) If not, then either the generic "thermal" ACPI driver may be used, or nothing can be done (other than a white list, if we really want to get hardware monitoring on some machines.) I propose to reword the message to: ACPI: Device may still be supported by an ACPI driver which I think is more correct. Comments and suggestions welcome. Signed-off-by: Jean Delvare Cc: Zhang Rui Cc: Len Brown Cc: Thomas Renninger --- drivers/acpi/osl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.31-rc8.orig/drivers/acpi/osl.c 2009-08-28 19:48:58.000000000 +0200 +++ linux-2.6.31-rc8/drivers/acpi/osl.c 2009-08-30 10:10:51.000000000 +0200 @@ -1182,7 +1182,8 @@ int acpi_check_resource_conflict(struct res_list_elem->name, (long long) res_list_elem->start, (long long) res_list_elem->end); - printk(KERN_INFO "ACPI: Device needs an ACPI driver\n"); + printk(KERN_INFO "ACPI: Device may still be supported" + " by an ACPI driver\n"); } if (acpi_enforce_resources == ENFORCE_RESOURCES_STRICT) return -EBUSY;