diff mbox

[17/26] asus-laptop: return proper error for store_ledd if write_acpi_int fail

Message ID 201007202219.o6KMJmJg021061@imap1.linux-foundation.org (mailing list archive)
State New, archived
Headers show

Commit Message

Andrew Morton July 20, 2010, 10:19 p.m. UTC
None
diff mbox

Patch

diff -puN drivers/platform/x86/asus-laptop.c~asus-laptop-return-proper-error-for-store_ledd-if-write_acpi_int-fail drivers/platform/x86/asus-laptop.c
--- a/drivers/platform/x86/asus-laptop.c~asus-laptop-return-proper-error-for-store_ledd-if-write_acpi_int-fail
+++ a/drivers/platform/x86/asus-laptop.c
@@ -796,10 +796,11 @@  static ssize_t store_ledd(struct device 
 
 	rv = parse_arg(buf, count, &value);
 	if (rv > 0) {
-		if (write_acpi_int(asus->handle, METHOD_LEDD, value))
+		if (write_acpi_int(asus->handle, METHOD_LEDD, value)) {
 			pr_warning("LED display write failed\n");
-		else
-			asus->ledd_status = (u32) value;
+			return -ENODEV;
+		}
+		asus->ledd_status = (u32) value;
 	}
 	return rv;
 }