From patchwork Mon Oct 1 20:28:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1532571 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id AF3A3DFE80 for ; Mon, 1 Oct 2012 20:28:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168Ab2JAU2l (ORCPT ); Mon, 1 Oct 2012 16:28:41 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:64692 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751252Ab2JAU2l (ORCPT ); Mon, 1 Oct 2012 16:28:41 -0400 Received: from klappe2.localnet (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mrbap4) with ESMTP (Nemesis) id 0MGi3N-1TE3d23eF7-00E7tf; Mon, 01 Oct 2012 22:28:34 +0200 From: Arnd Bergmann To: Josh Triplett Subject: Re: [PATCHv3 1/4] efi: Add a stub for efi_enter_virtual_mode on non-x86 Date: Mon, 1 Oct 2012 20:28:32 +0000 User-Agent: KMail/1.12.2 (Linux/3.5.0; KDE/4.3.2; x86_64; ; ) Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Len Brown , Matt Fleming , Olof Johansson , Matthew Garrett , David Howells , Rusty Russell , Jim Cromie , Peter Zijlstra , linux-acpi@vger.kernel.org References: <993c7f2ee7d53cc480280653a7df500db0882342.1347141698.git.josh@joshtriplett.org> In-Reply-To: <993c7f2ee7d53cc480280653a7df500db0882342.1347141698.git.josh@joshtriplett.org> MIME-Version: 1.0 Message-Id: <201210012028.32710.arnd@arndb.de> X-Provags-ID: V02:K0:kYF9wuay0WcF4tXmvQj5/7EjBIVx8JrNNS4sZpADjfz rVSKiVSAyhoTlCT1+gMfhWnslSVF1WbZ3bJkZM6swo3qhcvCjA CKU3Exsnnrwd3iV4B9YqCPhzHEfOk/EBMN7Lzetw/wlEdaxJ1P d6cIaNrUieS61DIiCmJ2nEQteHsmosjkWowRVDkQFoxRm9OfRX apY298Rb+U0j6rNBXacLGIEndIry5FoXBhB76PbvnlDESHSuJz 7gNj4AZ7kj2XzDxx9BSiplP6rutJJPepKUNSmVBlizxpPMpzel afBUnsEIQQtnGVoYHr6NMJmI7VMw8IrmYnk7eIZYiUOuaN9Aft pWD2/rAKyEcvJKpCr7vM= Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Saturday 08 September 2012, Josh Triplett wrote: > +#ifdef CONFIG_X86 > extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if possible */ > +#else > +static void efi_enter_virtual_mode(void) {} > +#endif This has suddenly appeared in linux-next now and is causing warnings. 8<--- efi: fix prototype for API stubs Some functions in the efi API have recently been added as versions for non-x86, but are missing an "inline" keyword, which causes these warnings: include/linux/efi.h:503:13: error: 'efi_enter_virtual_mode' defined but not used [-Werror=unused-function] include/linux/efi.h:504:13: error: 'efi_late_init' defined but not used [-Werror=unused-function] include/linux/efi.h:505:13: error: 'efi_free_boot_services' defined but not used [-Werror=unused-function] Signed-off-by: Arnd Bergmann --- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/efi.h b/include/linux/efi.h index 798bd1d..58f31c3 100644 --- a/include/linux/efi.h +++ b/include/linux/efi.h @@ -500,9 +500,9 @@ extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if pos extern void efi_late_init(void); extern void efi_free_boot_services(void); #else -static void efi_enter_virtual_mode(void) {} -static void efi_late_init(void) {} -static void efi_free_boot_services(void) {} +static inline void efi_enter_virtual_mode(void) {} +static inline void efi_late_init(void) {} +static inline void efi_free_boot_services(void) {} #endif extern void __iomem *efi_lookup_mapped_addr(u64 phys_addr); extern u64 efi_get_iobase (void);