| Message ID | 20130104222428.10275.2683.stgit@bhelgaas.mtv.corp.google.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Friday, January 04, 2013 03:24:28 PM Bjorn Helgaas wrote: > Add newlines to avoid run-on debug output. This has to go through ACPICA upstream. Bob, can you take it, please? Rafael > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > --- > drivers/acpi/acpica/hwvalid.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/acpica/hwvalid.c b/drivers/acpi/acpica/hwvalid.c > index b6aae58..04ab4a2 100644 > --- a/drivers/acpi/acpica/hwvalid.c > +++ b/drivers/acpi/acpica/hwvalid.c > @@ -142,7 +142,7 @@ acpi_hw_validate_io_request(acpi_io_address address, u32 bit_width) > byte_width = ACPI_DIV_8(bit_width); > last_address = address + byte_width - 1; > > - ACPI_DEBUG_PRINT((ACPI_DB_IO, "Address %p LastAddress %p Length %X", > + ACPI_DEBUG_PRINT((ACPI_DB_IO, "Address %p LastAddress %p Length %X\n", > ACPI_CAST_PTR(void, address), ACPI_CAST_PTR(void, > last_address), > byte_width)); > @@ -181,7 +181,7 @@ acpi_hw_validate_io_request(acpi_io_address address, u32 bit_width) > > if (acpi_gbl_osi_data >= port_info->osi_dependency) { > ACPI_DEBUG_PRINT((ACPI_DB_IO, > - "Denied AML access to port 0x%p/%X (%s 0x%.4X-0x%.4X)", > + "Denied AML access to port 0x%p/%X (%s 0x%.4X-0x%.4X)\n", > ACPI_CAST_PTR(void, address), > byte_width, port_info->name, > port_info->start, >
Yes. > -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@sisk.pl] > Sent: Friday, January 04, 2013 3:43 PM > To: Bjorn Helgaas; Moore, Robert > Cc: Len Brown; linux-acpi@vger.kernel.org; Zheng, Lv > Subject: Re: [PATCH] ACPICA: Add newlines to hwvalid debug output > > On Friday, January 04, 2013 03:24:28 PM Bjorn Helgaas wrote: > > Add newlines to avoid run-on debug output. > > This has to go through ACPICA upstream. > > Bob, can you take it, please? > > Rafael > > > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > --- > > drivers/acpi/acpica/hwvalid.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/acpica/hwvalid.c > > b/drivers/acpi/acpica/hwvalid.c index b6aae58..04ab4a2 100644 > > --- a/drivers/acpi/acpica/hwvalid.c > > +++ b/drivers/acpi/acpica/hwvalid.c > > @@ -142,7 +142,7 @@ acpi_hw_validate_io_request(acpi_io_address address, > u32 bit_width) > > byte_width = ACPI_DIV_8(bit_width); > > last_address = address + byte_width - 1; > > > > - ACPI_DEBUG_PRINT((ACPI_DB_IO, "Address %p LastAddress %p Length %X", > > + ACPI_DEBUG_PRINT((ACPI_DB_IO, "Address %p LastAddress %p Length > > +%X\n", > > ACPI_CAST_PTR(void, address), ACPI_CAST_PTR(void, > > last_address), > > byte_width)); > > @@ -181,7 +181,7 @@ acpi_hw_validate_io_request(acpi_io_address > > address, u32 bit_width) > > > > if (acpi_gbl_osi_data >= port_info->osi_dependency) { > > ACPI_DEBUG_PRINT((ACPI_DB_IO, > > - "Denied AML access to port 0x%p/%X > (%s 0x%.4X-0x%.4X)", > > + "Denied AML access to port 0x%p/%X > (%s 0x%.4X-0x%.4X)\n", > > ACPI_CAST_PTR(void, address), > > byte_width, port_info->name, > > port_info->start, > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center.
diff --git a/drivers/acpi/acpica/hwvalid.c b/drivers/acpi/acpica/hwvalid.c index b6aae58..04ab4a2 100644 --- a/drivers/acpi/acpica/hwvalid.c +++ b/drivers/acpi/acpica/hwvalid.c @@ -142,7 +142,7 @@ acpi_hw_validate_io_request(acpi_io_address address, u32 bit_width) byte_width = ACPI_DIV_8(bit_width); last_address = address + byte_width - 1; - ACPI_DEBUG_PRINT((ACPI_DB_IO, "Address %p LastAddress %p Length %X", + ACPI_DEBUG_PRINT((ACPI_DB_IO, "Address %p LastAddress %p Length %X\n", ACPI_CAST_PTR(void, address), ACPI_CAST_PTR(void, last_address), byte_width)); @@ -181,7 +181,7 @@ acpi_hw_validate_io_request(acpi_io_address address, u32 bit_width) if (acpi_gbl_osi_data >= port_info->osi_dependency) { ACPI_DEBUG_PRINT((ACPI_DB_IO, - "Denied AML access to port 0x%p/%X (%s 0x%.4X-0x%.4X)", + "Denied AML access to port 0x%p/%X (%s 0x%.4X-0x%.4X)\n", ACPI_CAST_PTR(void, address), byte_width, port_info->name, port_info->start,
Add newlines to avoid run-on debug output. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/acpi/acpica/hwvalid.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html