From patchwork Tue Aug 20 03:34:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerry Snitselaar X-Patchwork-Id: 2846826 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 172DC9F239 for ; Tue, 20 Aug 2013 03:34:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3EF3D203AF for ; Tue, 20 Aug 2013 03:34:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C30C20345 for ; Tue, 20 Aug 2013 03:34:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751951Ab3HTDeQ (ORCPT ); Mon, 19 Aug 2013 23:34:16 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43892 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751757Ab3HTDeP (ORCPT ); Mon, 19 Aug 2013 23:34:15 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r7K3YAxU026482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Aug 2013 03:34:11 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r7K3Y6ls011713 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 20 Aug 2013 03:34:09 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r7K3Y6J0014577; Tue, 20 Aug 2013 03:34:06 GMT Received: from cantor.us.oracle.com (/10.159.127.43) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 19 Aug 2013 20:34:06 -0700 Date: Mon, 19 Aug 2013 20:34:03 -0700 From: Jerry Snitselaar To: "Rafael J. Wysocki" Cc: Mika Westerberg , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION Message-ID: <20130820033403.GD4587@cantor.us.oracle.com> Reply-To: Jerry Snitselaar References: <1376702795-25912-1-git-send-email-jerry.snitselaar@oracle.com> <2870377.GVGv4QBgQK@vostro.rjw.lan> <20130819233528.GA4587@cantor.us.oracle.com> <1838503.PYpZe7GJ51@vostro.rjw.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1838503.PYpZe7GJ51@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue Aug 20 13, Rafael J. Wysocki wrote: > On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote: > > On Tue Aug 20 13, Rafael J. Wysocki wrote: > > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: > > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote: > > > > > Without MODULE_LICENSE set, I get the following with modprobe: > > > > > > > > > > acpi_i2c: module license 'unspecified' taints kernel. > > > > > acpi_i2c: Unknown symbol i2c_new_device (err 0) > > > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0) > > > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0) > > > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0) > > > > > > > > > > Signed-off-by: Jerry Snitselaar > > > > > > > > Looks good to me. > > > > > > > > Acked-by: Mika Westerbeg > > > > > > Well, OK, but do we need to be able to build that as a module? > > > > > > Maybe it should just be yes or no? > > > > > > Rafael > > > > > > > Perhaps have depends on I2C=y and be a bool instead of tristate? > > Yes, that's the idea. > Does this look okay Mika? [PATCH] acpi_i2c: do not build as loadable module Change from tristate to bool, and depend on I2C=y Signed-off-by: Jerry Snitselaar --- drivers/acpi/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 100bd72..183a309 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -181,8 +181,9 @@ config ACPI_DOCK drive bays such as the IBM Ultrabay and the Dell Module Bay. config ACPI_I2C - def_tristate I2C - depends on I2C + bool "I2C" + depends on I2C=y + default n help ACPI I2C enumeration support.