From patchwork Fri Jun 16 04:40:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9790517 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1454260326 for ; Fri, 16 Jun 2017 04:42:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1291A2855C for ; Fri, 16 Jun 2017 04:42:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0769228608; Fri, 16 Jun 2017 04:42:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A24B42855C for ; Fri, 16 Jun 2017 04:42:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752358AbdFPEme (ORCPT ); Fri, 16 Jun 2017 00:42:34 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36135 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751858AbdFPElP (ORCPT ); Fri, 16 Jun 2017 00:41:15 -0400 Received: by mail-wm0-f67.google.com with SMTP id d17so2754988wme.3 for ; Thu, 15 Jun 2017 21:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t/qwAF/AmBxw1aOGFWVouJxkB6yxVPzi87ec6SfAdXs=; b=kNljivsQH68TszAHwXgFwdeaFOc+Bpo9dpOEhHLlY7qbsQRAwCfRQf+XvV9GwcAVIq aRKRhY47UUuCzOILgVAaXzx7YCNH0NlBtPLCg0pj/fz3rq4LgoUDBV5yQTHYNkczpZvr 8we4kuQ53/JuJYCP/HOn4MUA5TL+GkG9nLts4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t/qwAF/AmBxw1aOGFWVouJxkB6yxVPzi87ec6SfAdXs=; b=Aw0zciajaWO8vnlWpEljkuLyL8WgoiaXD6E3geQjd/ijlPmWxkK4TN/AJYy8m9XnmE tpMKbV+mW9xPc5WDr9ib8tQVaMItpXSAkvhD1NNOZVrs5coUM3owqnNDg5G/uPWSVpQ4 JAo433uX07Vam+QGIbRTuNPkZaLJUZehyf2d0GFZgnzv01Wsu/DjXd35W4KfxfFkMo5A SOfD7cbIW8oYAeq5YzO5l2TXodizByXRLzuVKtNv61X+bVM5WpCuG4jKvSCnyl3J7Aj5 Jl13dXYmTdxGIpmApmFPZ1zE6CFozTVE6xumqCxVjPayafvRl62dqFfF4vhoBFCBnoSa hZXw== X-Gm-Message-State: AKS2vOzs09UJH3aJTXhFgbTrzHEbSMIqNoe4d3FObn5slzqNLsIHPGUK jwJ/Dcz6TI6DJ+/B X-Received: by 10.28.238.213 with SMTP id j82mr5550895wmi.33.1497588074107; Thu, 15 Jun 2017 21:41:14 -0700 (PDT) Received: from kmp-mobile.hq.kempniu.pl (kmp-mobile.hq.kempniu.pl. [2001:470:64df:111::2d90]) by smtp.googlemail.com with ESMTPSA id g3sm2026681wrd.11.2017.06.15.21.41.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Jun 2017 21:41:13 -0700 (PDT) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] platform/x86: fujitsu-laptop: sanitize hotkey input device identification Date: Fri, 16 Jun 2017 06:40:55 +0200 Message-Id: <20170616044058.30443-5-kernel@kempniu.pl> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170616044058.30443-1-kernel@kempniu.pl> References: <20170616044058.30443-1-kernel@kempniu.pl> MIME-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In the case of brightness-related FUJ02B1 ACPI device, initializing the input device associated with it identically as acpi-video initializes its input device makes sense. However, using the same data for the input device associated with the FUJ02E3 ACPI device makes little sense, because the latter has nothing to do with video and assigning an arbitrary product ID to it is redundant. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 06d04500dac0..5c0dc2126313 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -555,13 +555,12 @@ static int acpi_fujitsu_laptop_input_setup(struct acpi_device *device) if (!priv->input) return -ENOMEM; - snprintf(priv->phys, sizeof(priv->phys), "%s/video/input0", + snprintf(priv->phys, sizeof(priv->phys), "%s/input0", acpi_device_hid(device)); priv->input->name = acpi_device_name(device); priv->input->phys = priv->phys; priv->input->id.bustype = BUS_HOST; - priv->input->id.product = 0x06; dmi_check_system(fujitsu_laptop_dmi_table); ret = sparse_keymap_setup(priv->input, keymap, NULL);