From patchwork Fri Jul 14 12:07:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9840799 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8132E60393 for ; Fri, 14 Jul 2017 12:13:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 749062875A for ; Fri, 14 Jul 2017 12:13:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6883228779; Fri, 14 Jul 2017 12:13:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F0DA028778 for ; Fri, 14 Jul 2017 12:13:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754214AbdGNMNO (ORCPT ); Fri, 14 Jul 2017 08:13:14 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:64213 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932170AbdGNMNL (ORCPT ); Fri, 14 Jul 2017 08:13:11 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0MDxlf-1dRGlY1LOZ-00HPfU; Fri, 14 Jul 2017 14:11:47 +0200 From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Mika Westerberg , Andy Shevchenko , Linus Walleij Cc: Greg Kroah-Hartman , Linus Torvalds , Guenter Roeck , akpm@linux-foundation.org, netdev@vger.kernel.org, "David S . Miller" , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, x86@kernel.org, Arnd Bergmann , Hans de Goede , "Rafael J. Wysocki" , Wei Yongjun , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH 18/22] gpio: acpi: fix string overflow for large pin numbers Date: Fri, 14 Jul 2017 14:07:10 +0200 Message-Id: <20170714120720.906842-19-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170714120720.906842-1-arnd@arndb.de> References: <20170714120720.906842-1-arnd@arndb.de> X-Provags-ID: V03:K0:svydAwJjRiW1PP1kUc+lEX50KZYH/juMswWzA+MAZdFAykVUH3D CRMwb+92cSH994sKWp8fPOFGXLDyCwY5dNoouxNOyfcfEfstjjR/yL4P2GTSiMMR+T1iG5I 1HG7AnhZymy1ME9l48G07lzbRX5H5NsZGj2fNabgY9y/cCN8abzaKrqVJrd/9oHAUpeNnDL NMqLfhCfIyMElNsX1oEug== X-UI-Out-Filterresults: notjunk:1; V01:K0:piGDOK6iX9s=:bXLMzTZTLMcdGFXG6cVW5t lVDm/ZvJAlzudfewiIaWsJBnesLyqjRS9IdzzA+u2ebkejNxm3hLor9r31Qt0Q6AfkbR+ijLh SWjwxHieg+FCRzCGGWdt8e/VQ5k3A7UNx9EzyQyraorIINbcmQKD0D73YDzWiYn6BBEd6f8qK GbYGHZwJiuMY4sYoPyMCDfbomkD1PQ6ArDzDRWzn6m7YbVJWddO36oFNR5dPbyEZHlAXvyVH5 CPsWC5PhLlHm4NSa9Nz6FWfQG+LehMQhc/rn/EcCbUqv9lny3UdQqVmNSATEtx0tyqAVqAuDZ mtZEjno+c6z3J+w6SpUp0arUu5SsGJxlxqE0DHdyg0J6RzGDL1M/uIkT9rn+XBuNuJTOmsq+E +e3zitIwDJdWLzEDXaUD4IEYF2aEcGrOjiVA1/WCgjf9Fgls6mIy2DsWYtMWvXhnp0mmJVV/8 Svf/8Cf+NxBU95R0NIl+ptwcLfJSQQv8o4yBo8/NJTZgVMKsQUy1gsAu/+3eMQiJaHIwzF7go /KwzuvY/aYNSP9+JzbgclGz8852buDxCDsNVGScn1UitBqRGv6LiGQ/zRRt2lRVugHhmZ4wEK cItDM25SIr5NVRoeaYBO/3+nzrXYfbFe1QL6FmWvipZvBNatFNZN9lq3lEZqYXV0fWAiungnn WkHpgGzVHht4i+fHF4fCYEZ0KuMLUApnVZpJYF9/rtRiVgz3jT8rRH4J5tgpgkC/qd4RSa09V P7Goi4aRhG1bb6401TlXsy1TEaE63hDaPRrisg== Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP gcc-7 notices that the pin_table is an array of 16-bit numbers, but we assume it can be printed as a two-character hexadecimal string: drivers/gpio/gpiolib-acpi.c: In function 'acpi_gpiochip_request_interrupt': drivers/gpio/gpiolib-acpi.c:206:24: warning: '%02X' directive writing between 2 and 4 bytes into a region of size 3 [-Wformat-overflow=] sprintf(ev_name, "_%c%02X", ^~~~ drivers/gpio/gpiolib-acpi.c:206:20: note: directive argument in the range [0, 65535] sprintf(ev_name, "_%c%02X", ^~~~~~~~~ drivers/gpio/gpiolib-acpi.c:206:3: note: 'sprintf' output between 5 and 7 bytes into a destination of size 5 sprintf(ev_name, "_%c%02X", ^~~~~~~~~~~~~~~~~~~~~~~~~~~ agpio->triggering == ACPI_EDGE_SENSITIVE ? 'E' : 'L', ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ pin); ~~~~ This can't be right, so this changes it to truncate the number to an 8-bit pin number. Fixes: 0d1c28a449c6 ("gpiolib-acpi: Add ACPI5 event model support to gpio.") Signed-off-by: Arnd Bergmann --- drivers/gpio/gpiolib-acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index c9b42dd12dfa..c3faea724af8 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -205,7 +205,7 @@ static acpi_status acpi_gpiochip_request_interrupt(struct acpi_resource *ares, char ev_name[5]; sprintf(ev_name, "_%c%02X", agpio->triggering == ACPI_EDGE_SENSITIVE ? 'E' : 'L', - pin); + (u8)pin); if (ACPI_SUCCESS(acpi_get_handle(handle, ev_name, &evt_handle))) handler = acpi_gpio_irq_handler; }