diff mbox

[RESEND] mailbox: pcc: Drop uninformative output during boot

Message ID 20170801124357.18344-1-punit.agrawal@arm.com (mailing list archive)
State Accepted, archived
Delegated to: Rafael Wysocki
Headers show

Commit Message

Punit Agrawal Aug. 1, 2017, 12:43 p.m. UTC
When booting on an ACPI enabled system that does not provide the
Platform Communications Channel Table (PCCT), the pcc mailbox driver
prints -

[    0.484261] PCCT header not found.

during probe before returning -ENODEV.

This message clutters the bootlog and doesn't provide any useful
information. Drop this message.

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>
Acked-by: Alexey Klimov <alexey.klimov@arm.com>
---

Hi Rafael,

Re-sending the patch with linux-acpi on cc and tags applied as
requested. If there are no objections please consider merging.

Thanks,
Punit

 drivers/mailbox/pcc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Rafael J. Wysocki Aug. 10, 2017, 11:08 p.m. UTC | #1
On Tuesday, August 1, 2017 2:43:57 PM CEST Punit Agrawal wrote:
> When booting on an ACPI enabled system that does not provide the
> Platform Communications Channel Table (PCCT), the pcc mailbox driver
> prints -
> 
> [    0.484261] PCCT header not found.
> 
> during probe before returning -ENODEV.
> 
> This message clutters the bootlog and doesn't provide any useful
> information. Drop this message.
> 
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Acked-by: Alexey Klimov <alexey.klimov@arm.com>
> ---
> 
> Hi Rafael,
> 
> Re-sending the patch with linux-acpi on cc and tags applied as
> requested. If there are no objections please consider merging.
> 
> Thanks,
> Punit
> 
>  drivers/mailbox/pcc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index ac91fd0d62c6..3d83cdc11ab5 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -457,10 +457,8 @@ static int __init acpi_pcc_probe(void)
>  	/* Search for PCCT */
>  	status = acpi_get_table(ACPI_SIG_PCCT, 0, &pcct_tbl);
>  
> -	if (ACPI_FAILURE(status) || !pcct_tbl) {
> -		pr_warn("PCCT header not found.\n");
> +	if (ACPI_FAILURE(status) || !pcct_tbl)
>  		return -ENODEV;
> -	}
>  
>  	count = acpi_table_parse_entries(ACPI_SIG_PCCT,
>  			sizeof(struct acpi_table_pcct),
> 

Applied, thanks!


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
index ac91fd0d62c6..3d83cdc11ab5 100644
--- a/drivers/mailbox/pcc.c
+++ b/drivers/mailbox/pcc.c
@@ -457,10 +457,8 @@  static int __init acpi_pcc_probe(void)
 	/* Search for PCCT */
 	status = acpi_get_table(ACPI_SIG_PCCT, 0, &pcct_tbl);
 
-	if (ACPI_FAILURE(status) || !pcct_tbl) {
-		pr_warn("PCCT header not found.\n");
+	if (ACPI_FAILURE(status) || !pcct_tbl)
 		return -ENODEV;
-	}
 
 	count = acpi_table_parse_entries(ACPI_SIG_PCCT,
 			sizeof(struct acpi_table_pcct),