| Message ID | 20200509093430.1983-1-yuzenghui@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | ACPI/IORT: Remove the unused __get_pci_rid() | expand |
On 2020/5/9 17:34, Zenghui Yu wrote: > Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for > IOMMUs"), __get_pci_rid() has become actually unused and can be removed. > > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> Looks good to me, Acked-by: Hanjun Guo <guohanjun@huawei.com>
On 2020/5/9 17:56, Hanjun Guo wrote: > On 2020/5/9 17:34, Zenghui Yu wrote: >> Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for >> IOMMUs"), __get_pci_rid() has become actually unused and can be removed. >> >> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> > > Looks good to me, > > Acked-by: Hanjun Guo <guohanjun@huawei.com> Hi Will, Could you please take this patch [*] into v5.8 (if it's not too late)? I've tried and it can be applied to for-next/acpi cleanly. [*] https://lore.kernel.org/linux-acpi/20200509093430.1983-1-yuzenghui@huawei.com/ Thanks, Zenghui
On Sat, May 09, 2020 at 05:34:30PM +0800, Zenghui Yu wrote: > Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for > IOMMUs"), __get_pci_rid() has become actually unused and can be removed. > > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> > --- > drivers/acpi/arm64/iort.c | 9 --------- > 1 file changed, 9 deletions(-) Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> If we miss v5.8 (which I think it is likely, even though this patch is just removing dead code so it is safe at this stage) I will resend it for v5.9 - not a problem. Lorenzo > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index 7d04424189df..ec94dbb60c7a 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -789,15 +789,6 @@ void acpi_configure_pmsi_domain(struct device *dev) > dev_set_msi_domain(dev, msi_domain); > } > > -static int __maybe_unused __get_pci_rid(struct pci_dev *pdev, u16 alias, > - void *data) > -{ > - u32 *rid = data; > - > - *rid = alias; > - return 0; > -} > - > #ifdef CONFIG_IOMMU_API > static struct acpi_iort_node *iort_get_msi_resv_iommu(struct device *dev) > { > -- > 2.19.1 >
On Sat, 9 May 2020 17:34:30 +0800, Zenghui Yu wrote: > Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for > IOMMUs"), __get_pci_rid() has become actually unused and can be removed. Applied to arm64 (for-next/acpi), thanks! [1/1] ACPI/IORT: Remove the unused __get_pci_rid() https://git.kernel.org/arm64/c/09cda9a71350 Cheers,
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c index 7d04424189df..ec94dbb60c7a 100644 --- a/drivers/acpi/arm64/iort.c +++ b/drivers/acpi/arm64/iort.c @@ -789,15 +789,6 @@ void acpi_configure_pmsi_domain(struct device *dev) dev_set_msi_domain(dev, msi_domain); } -static int __maybe_unused __get_pci_rid(struct pci_dev *pdev, u16 alias, - void *data) -{ - u32 *rid = data; - - *rid = alias; - return 0; -} - #ifdef CONFIG_IOMMU_API static struct acpi_iort_node *iort_get_msi_resv_iommu(struct device *dev) {
Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for IOMMUs"), __get_pci_rid() has become actually unused and can be removed. Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> --- drivers/acpi/arm64/iort.c | 9 --------- 1 file changed, 9 deletions(-)