diff mbox series

[v3,2/3] ACPI: EC: Fix oops when removing custom query handlers

Message ID 20230324202628.76966-3-W_Armin@gmx.de (mailing list archive)
State Mainlined, archived
Headers show
Series ACPI: SBS: Fix various issues | expand

Commit Message

Armin Wolf March 24, 2023, 8:26 p.m. UTC 
When removing custom query handlers, the handler might still
be used inside the EC query workqueue, causing a kernel oops
if the module holding the callback function was already unloaded.

Fix this by flushing the EC query workqueue when removing
custom query handlers.

Tested on a Acer Travelmate 4002WLMi

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
 drivers/acpi/ec.c | 1 +
 1 file changed, 1 insertion(+)

--
2.30.2
diff mbox series

Patch

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index f84905dbd8ca..4ae017391533 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1132,6 +1132,7 @@  static void acpi_ec_remove_query_handlers(struct acpi_ec *ec,
 void acpi_ec_remove_query_handler(struct acpi_ec *ec, u8 query_bit)
 {
 	acpi_ec_remove_query_handlers(ec, false, query_bit);
+	flush_workqueue(ec_query_wq);
 }
 EXPORT_SYMBOL_GPL(acpi_ec_remove_query_handler);