| Message ID | 20230410205305.1649678-7-daniel.lezcano@linaro.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | None | expand |
On Mon, Apr 10, 2023 at 10:53 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > The ACPI thermal driver creates a link in the thermal zone device > sysfs directory pointing to the device sysfs directory. At the same > time, it creates a back pointer link from the device to the thermal > zone device sysfs directory. > > From a generic perspective, having a device pointer in the sysfs > thermal zone directory may make sense. But the opposite is not true as > the same driver can be related to multiple thermal zones. > > The usage of these information is very specific to ACPI and it is > questionable if they are really needed. > > Let's make the code optional and disable it by default. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/acpi/thermal.c | 62 ++++++++++++++++++++++++++++-------------- > 1 file changed, 42 insertions(+), 20 deletions(-) > > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c > index 5763db4528b8..70f1d28810f2 100644 > --- a/drivers/acpi/thermal.c > +++ b/drivers/acpi/thermal.c > @@ -787,9 +787,44 @@ static struct thermal_zone_device_ops acpi_thermal_zone_ops = { > .critical = acpi_thermal_zone_device_critical, > }; > > +#ifdef CONFIG_THERMAL_SYSFS_OBSOLETE_SINGULARITY It is OK to move the code to the separate functions below, but it is not OK to make it depend on the Kconfig option above. The extra sysfs things were added in different drivers for different reasons. Making them all depend on one Kconfig option is just wrong. > +static int acpi_thermal_zone_sysfs_add(struct acpi_thermal *tz) > +{ > + struct device *tzdev = thermal_zone_device(tz->thermal_zone); > + int ret; > + > + ret = sysfs_create_link(&tz->device->dev.kobj, > + &tzdev->kobj, "thermal_zone"); > + if (ret) > + return ret; > + > + ret = sysfs_create_link(&tzdev->kobj, > + &tz->device->dev.kobj, "device"); > + if (ret) > + sysfs_remove_link(&tz->device->dev.kobj, "thermal_zone"); > + > + return ret; > +} > + > +static void acpi_thermal_zone_sysfs_remove(struct acpi_thermal *tz) > +{ > + struct device *tzdev = thermal_zone_device(tz->thermal_zone); > + > + sysfs_remove_link(&tz->device->dev.kobj, "thermal_zone"); > + sysfs_remove_link(&tzdev->kobj, "device"); > +} > +#else > +static inline int acpi_thermal_zone_sysfs_add(struct acpi_thermal *tz) > +{ > + return 0; > +} > +static inline void acpi_thermal_zone_sysfs_remove(struct acpi_thermal *tz) > +{ > +} > +#endif > + > static int acpi_thermal_register_thermal_zone(struct acpi_thermal *tz) > { > - struct device *tzdev; > int trips = 0; > int result; > acpi_status status; > @@ -821,23 +856,15 @@ static int acpi_thermal_register_thermal_zone(struct acpi_thermal *tz) > if (IS_ERR(tz->thermal_zone)) > return -ENODEV; > > - tzdev = thermal_zone_device(tz->thermal_zone); > - > - result = sysfs_create_link(&tz->device->dev.kobj, > - &tzdev->kobj, "thermal_zone"); > + result = acpi_thermal_zone_sysfs_add(tz); > if (result) > goto unregister_tzd; > - > - result = sysfs_create_link(&tzdev->kobj, > - &tz->device->dev.kobj, "device"); > - if (result) > - goto remove_tz_link; > - > + > status = acpi_bus_attach_private_data(tz->device->handle, > tz->thermal_zone); > if (ACPI_FAILURE(status)) { > result = -ENODEV; > - goto remove_dev_link; > + goto remove_links; > } > > result = thermal_zone_device_enable(tz->thermal_zone); > @@ -851,10 +878,8 @@ static int acpi_thermal_register_thermal_zone(struct acpi_thermal *tz) > > acpi_bus_detach: > acpi_bus_detach_private_data(tz->device->handle); > -remove_dev_link: > - sysfs_remove_link(&tzdev->kobj, "device"); > -remove_tz_link: > - sysfs_remove_link(&tz->device->dev.kobj, "thermal_zone"); > +remove_links: > + acpi_thermal_zone_sysfs_remove(tz); > unregister_tzd: > thermal_zone_device_unregister(tz->thermal_zone); > > @@ -863,10 +888,7 @@ static int acpi_thermal_register_thermal_zone(struct acpi_thermal *tz) > > static void acpi_thermal_unregister_thermal_zone(struct acpi_thermal *tz) > { > - struct device *tzdev = thermal_zone_device(tz->thermal_zone); > - > - sysfs_remove_link(&tz->device->dev.kobj, "thermal_zone"); > - sysfs_remove_link(&tzdev->kobj, "device"); > + acpi_thermal_zone_sysfs_remove(tz); > thermal_zone_device_unregister(tz->thermal_zone); > tz->thermal_zone = NULL; > acpi_bus_detach_private_data(tz->device->handle); > -- > 2.34.1 >
On 11/04/2023 20:26, Rafael J. Wysocki wrote: > On Mon, Apr 10, 2023 at 10:53 PM Daniel Lezcano > <daniel.lezcano@linaro.org> wrote: >> >> The ACPI thermal driver creates a link in the thermal zone device >> sysfs directory pointing to the device sysfs directory. At the same >> time, it creates a back pointer link from the device to the thermal >> zone device sysfs directory. >> >> From a generic perspective, having a device pointer in the sysfs >> thermal zone directory may make sense. But the opposite is not true as >> the same driver can be related to multiple thermal zones. >> >> The usage of these information is very specific to ACPI and it is >> questionable if they are really needed. >> >> Let's make the code optional and disable it by default. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> --- >> drivers/acpi/thermal.c | 62 ++++++++++++++++++++++++++++-------------- >> 1 file changed, 42 insertions(+), 20 deletions(-) >> >> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c >> index 5763db4528b8..70f1d28810f2 100644 >> --- a/drivers/acpi/thermal.c >> +++ b/drivers/acpi/thermal.c >> @@ -787,9 +787,44 @@ static struct thermal_zone_device_ops acpi_thermal_zone_ops = { >> .critical = acpi_thermal_zone_device_critical, >> }; >> >> +#ifdef CONFIG_THERMAL_SYSFS_OBSOLETE_SINGULARITY > > It is OK to move the code to the separate functions below, but it is > not OK to make it depend on the Kconfig option above. > > The extra sysfs things were added in different drivers for different > reasons. Making them all depend on one Kconfig option is just wrong. Ok, I'll do the changes accordingly. Thanks for reviewing the series [ ... ]
diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c index 5763db4528b8..70f1d28810f2 100644 --- a/drivers/acpi/thermal.c +++ b/drivers/acpi/thermal.c @@ -787,9 +787,44 @@ static struct thermal_zone_device_ops acpi_thermal_zone_ops = { .critical = acpi_thermal_zone_device_critical, }; +#ifdef CONFIG_THERMAL_SYSFS_OBSOLETE_SINGULARITY +static int acpi_thermal_zone_sysfs_add(struct acpi_thermal *tz) +{ + struct device *tzdev = thermal_zone_device(tz->thermal_zone); + int ret; + + ret = sysfs_create_link(&tz->device->dev.kobj, + &tzdev->kobj, "thermal_zone"); + if (ret) + return ret; + + ret = sysfs_create_link(&tzdev->kobj, + &tz->device->dev.kobj, "device"); + if (ret) + sysfs_remove_link(&tz->device->dev.kobj, "thermal_zone"); + + return ret; +} + +static void acpi_thermal_zone_sysfs_remove(struct acpi_thermal *tz) +{ + struct device *tzdev = thermal_zone_device(tz->thermal_zone); + + sysfs_remove_link(&tz->device->dev.kobj, "thermal_zone"); + sysfs_remove_link(&tzdev->kobj, "device"); +} +#else +static inline int acpi_thermal_zone_sysfs_add(struct acpi_thermal *tz) +{ + return 0; +} +static inline void acpi_thermal_zone_sysfs_remove(struct acpi_thermal *tz) +{ +} +#endif + static int acpi_thermal_register_thermal_zone(struct acpi_thermal *tz) { - struct device *tzdev; int trips = 0; int result; acpi_status status; @@ -821,23 +856,15 @@ static int acpi_thermal_register_thermal_zone(struct acpi_thermal *tz) if (IS_ERR(tz->thermal_zone)) return -ENODEV; - tzdev = thermal_zone_device(tz->thermal_zone); - - result = sysfs_create_link(&tz->device->dev.kobj, - &tzdev->kobj, "thermal_zone"); + result = acpi_thermal_zone_sysfs_add(tz); if (result) goto unregister_tzd; - - result = sysfs_create_link(&tzdev->kobj, - &tz->device->dev.kobj, "device"); - if (result) - goto remove_tz_link; - + status = acpi_bus_attach_private_data(tz->device->handle, tz->thermal_zone); if (ACPI_FAILURE(status)) { result = -ENODEV; - goto remove_dev_link; + goto remove_links; } result = thermal_zone_device_enable(tz->thermal_zone); @@ -851,10 +878,8 @@ static int acpi_thermal_register_thermal_zone(struct acpi_thermal *tz) acpi_bus_detach: acpi_bus_detach_private_data(tz->device->handle); -remove_dev_link: - sysfs_remove_link(&tzdev->kobj, "device"); -remove_tz_link: - sysfs_remove_link(&tz->device->dev.kobj, "thermal_zone"); +remove_links: + acpi_thermal_zone_sysfs_remove(tz); unregister_tzd: thermal_zone_device_unregister(tz->thermal_zone); @@ -863,10 +888,7 @@ static int acpi_thermal_register_thermal_zone(struct acpi_thermal *tz) static void acpi_thermal_unregister_thermal_zone(struct acpi_thermal *tz) { - struct device *tzdev = thermal_zone_device(tz->thermal_zone); - - sysfs_remove_link(&tz->device->dev.kobj, "thermal_zone"); - sysfs_remove_link(&tzdev->kobj, "device"); + acpi_thermal_zone_sysfs_remove(tz); thermal_zone_device_unregister(tz->thermal_zone); tz->thermal_zone = NULL; acpi_bus_detach_private_data(tz->device->handle);
The ACPI thermal driver creates a link in the thermal zone device sysfs directory pointing to the device sysfs directory. At the same time, it creates a back pointer link from the device to the thermal zone device sysfs directory. From a generic perspective, having a device pointer in the sysfs thermal zone directory may make sense. But the opposite is not true as the same driver can be related to multiple thermal zones. The usage of these information is very specific to ACPI and it is questionable if they are really needed. Let's make the code optional and disable it by default. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/acpi/thermal.c | 62 ++++++++++++++++++++++++++++-------------- 1 file changed, 42 insertions(+), 20 deletions(-)