diff mbox series

ACPI: s2idle: fix section mismatch warning

Message ID 20230601213319.3304080-1-arnd@kernel.org (mailing list archive)
State Mainlined, archived
Headers show
Series ACPI: s2idle: fix section mismatch warning | expand

Commit Message

Arnd Bergmann June 1, 2023, 9:33 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The acpi_sleep_suspend_setup() function is missing an __init annotation,
which causes a warning in rare configurations that end up not inlining
it into its caller:

WARNING: modpost: vmlinux.o: section mismatch in reference: acpi_sleep_suspend_setup (section: .text) -> acpi_s2idle_setup (section: .init.text)

It's only called from an __init function, so adding the annotation is
correct here.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/acpi/sleep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rafael J. Wysocki June 5, 2023, 5:16 p.m. UTC | #1 
On Thu, Jun 1, 2023 at 11:33 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The acpi_sleep_suspend_setup() function is missing an __init annotation,
> which causes a warning in rare configurations that end up not inlining
> it into its caller:
>
> WARNING: modpost: vmlinux.o: section mismatch in reference: acpi_sleep_suspend_setup (section: .text) -> acpi_s2idle_setup (section: .init.text)
>
> It's only called from an __init function, so adding the annotation is
> correct here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/acpi/sleep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index 72470b9f16c45..552adc04743b5 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -840,7 +840,7 @@ void __weak acpi_s2idle_setup(void)
>         s2idle_set_ops(&acpi_s2idle_ops);
>  }
>
> -static void acpi_sleep_suspend_setup(void)
> +static void __init acpi_sleep_suspend_setup(void)
>  {
>         bool suspend_ops_needed = false;
>         int i;
> --

Applied as 6.5 material, thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index 72470b9f16c45..552adc04743b5 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -840,7 +840,7 @@  void __weak acpi_s2idle_setup(void)
 	s2idle_set_ops(&acpi_s2idle_ops);
 }
 
-static void acpi_sleep_suspend_setup(void)
+static void __init acpi_sleep_suspend_setup(void)
 {
 	bool suspend_ops_needed = false;
 	int i;