diff mbox series

[v2,2/2] amba: bus: Enable compile testing

Message ID 20231002132635.2595382-2-andriy.shevchenko@linux.intel.com (mailing list archive)
State Handled Elsewhere, archived
Headers show
Series [v2,1/2] amba: bus: balance firmware node reference counting | expand

Commit Message

Andy Shevchenko Oct. 2, 2023, 1:26 p.m. UTC
There is no architecture specific code in the implementation of
AMBA bus, let's enable compile testing for it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

v2: new patch to make it easier to compile test on non-ARM

 drivers/amba/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

kernel test robot Oct. 2, 2023, 3:19 p.m. UTC | #1
Hi Andy,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on robh/for-next soc/for-next linus/master v6.6-rc4 next-20230929]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/amba-bus-Enable-compile-testing/20231002-213425
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20231002132635.2595382-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v2 2/2] amba: bus: Enable compile testing
config: powerpc-randconfig-002-20231002 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231002/202310022317.qmuYgpwj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310022317.qmuYgpwj-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/amba/Kconfig:4: syntax error
   drivers/amba/Kconfig:3: invalid statement
   make[3]: *** [scripts/kconfig/Makefile:77: oldconfig] Error 1 shuffle=3457451660
   make[2]: *** [Makefile:697: oldconfig] Error 2 shuffle=3457451660
   make[1]: *** [Makefile:234: __sub-make] Error 2 shuffle=3457451660
   make[1]: Target 'oldconfig' not remade because of errors.
   make: *** [Makefile:234: __sub-make] Error 2 shuffle=3457451660
   make: Target 'oldconfig' not remade because of errors.
--
>> drivers/amba/Kconfig:4: syntax error
   drivers/amba/Kconfig:3: invalid statement
   make[3]: *** [scripts/kconfig/Makefile:77: olddefconfig] Error 1 shuffle=3457451660
   make[2]: *** [Makefile:697: olddefconfig] Error 2 shuffle=3457451660
   make[1]: *** [Makefile:234: __sub-make] Error 2 shuffle=3457451660
   make[1]: Target 'olddefconfig' not remade because of errors.
   make: *** [Makefile:234: __sub-make] Error 2 shuffle=3457451660
   make: Target 'olddefconfig' not remade because of errors.


vim +4 drivers/amba/Kconfig

bd968d59ad1bf0 Thierry Reding 2014-07-29 @4
Rob Herring Oct. 2, 2023, 5:38 p.m. UTC | #2
On Mon, Oct 2, 2023 at 8:32 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> There is no architecture specific code in the implementation of
> AMBA bus, let's enable compile testing for it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> v2: new patch to make it easier to compile test on non-ARM
>
>  drivers/amba/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/amba/Kconfig b/drivers/amba/Kconfig
> index fb6c7e0b4cce..9ff4638550c8 100644
> --- a/drivers/amba/Kconfig
> +++ b/drivers/amba/Kconfig
> @@ -1,6 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  config ARM_AMBA
> -       bool
> +       bool "AMBA bus support" || if COMPILE_TEST

Other than not compile testing a compile test enabling patch, it's
really "Arm (AMBA) Primecell Device bus". Despite the naming, AMBA
encompasses lots of Arm defined buses, but what this bus type is is
just peripherals which have the Primecell device ID registers.

Rob
diff mbox series

Patch

diff --git a/drivers/amba/Kconfig b/drivers/amba/Kconfig
index fb6c7e0b4cce..9ff4638550c8 100644
--- a/drivers/amba/Kconfig
+++ b/drivers/amba/Kconfig
@@ -1,6 +1,6 @@ 
 # SPDX-License-Identifier: GPL-2.0
 config ARM_AMBA
-	bool
+	bool "AMBA bus support" || if COMPILE_TEST
 
 if ARM_AMBA