From patchwork Wed Nov 1 10:51:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sakari Ailus X-Patchwork-Id: 13442766 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B85E1079D for ; Wed, 1 Nov 2023 10:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fJFLxzCL" Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1448C118 for ; Wed, 1 Nov 2023 03:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698835872; x=1730371872; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NI0pY1bRqiaMjrT3kfnkep6s61xU5gVy8tAflJrv8IY=; b=fJFLxzCLRENNI+yHBWiP06EQxUTSBB5zk0IBCp83w0zKioJdx/IweU79 /uAi1hd1bnxNaIvmjtait1kFqzGVeDmOX3aA1Fsf0B5MwPD/QYPpQQ9Qb g81+y+Tkll8cNPCeZOTMBKxXZYRI5wdqhbXrlY4D0lwQzMDw7viKZbymT DvnW9UGDInOOagR3Op+l+GnWh+pESmbxoDwOC9o/gaQRh5ufrDPVZDSxy WcU7KxA39UmYkMYJUdHA9KfbkY3guoZf6gbWFVI+ZAiw2wVZbS04L44ai lsngf9+SaAh+eT/JLRqC9l65EAu4a6gSoY5NLhhRM6a03IFoAJyqOkXcQ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="368682696" X-IronPort-AV: E=Sophos;i="6.03,268,1694761200"; d="scan'208";a="368682696" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 03:51:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="760902865" X-IronPort-AV: E=Sophos;i="6.03,268,1694761200"; d="scan'208";a="760902865" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 03:51:06 -0700 Received: from svinhufvud.ger.corp.intel.com (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 2B7481209FB; Wed, 1 Nov 2023 12:51:03 +0200 (EET) From: Sakari Ailus To: linux-acpi@vger.kernel.org Cc: andriy.shevchenko@linux.intel.com, Daniel Scally , Heikki Krogerus , "Rafael J. Wysocki" Subject: [PATCH v2 2/3] software node: Let args be NULL in software_node_get_reference_args Date: Wed, 1 Nov 2023 12:51:01 +0200 Message-Id: <20231101105102.1154620-3-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231101105102.1154620-1-sakari.ailus@linux.intel.com> References: <20231101105102.1154620-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 fwnode_get_property_reference() may not be called with args argument NULL and while OF already supports this. Add the missing NULL check. The purpose is to be able to count the references. Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()") Signed-off-by: Sakari Ailus --- drivers/base/swnode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c index 1886995a0b3a..079bd14bdedc 100644 --- a/drivers/base/swnode.c +++ b/drivers/base/swnode.c @@ -541,6 +541,9 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode, if (nargs > NR_FWNODE_REFERENCE_ARGS) return -EINVAL; + if (!args) + return 0; + args->fwnode = software_node_get(refnode); args->nargs = nargs;