From patchwork Sun Jan 14 17:19:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13519195 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B109E5CAF; Sun, 14 Jan 2024 17:20:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rXziJ5om" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D19FDC43390; Sun, 14 Jan 2024 17:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705252838; bh=Ukabpf2CYiS7klSJyLWLhreXlpdkCnBkQQ35UjxJ0yE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rXziJ5ommQ1AJg3C53ZVKIG1QC6edP2v2Ll2POveAbrGn81ItuGN4rUZQk7kdWc3F DbBB1aQ8/cK47PsEMtA7Vw3setAMCc3WZAMvju6fEB+H6eW6pl5uFCITOZL5uZIS1m GyaaK4rwr9v8Js9OyYAISoXSBIeprvbHNj9kjFOB/5wayvtrN9K5ZUKED57ZS8Q+Tg 17OguujX5MZsf1d/ee+ZjATjEDbhL4XoPamWTUDxvKkZ8vMVfFXBdEsRUkLu8a9wD8 JkZ9kQvJ2NJgM9gMWtVwfBoZ4AxMF4bdlILLJpAEnUz7ihP57aE6k6NVs8mk2CgoiT iOhVUywpHj6kw== From: Jonathan Cameron To: linux-iio@vger.kernel.org, "Rafael J . Wysocki" , Len Brown , linux-acpi@vger.kernel.org, Andy Shevchenko , Greg Kroah-Hartman , Daniel Scally , Heikki Krogerus , Sakari Ailus Cc: =?utf-8?q?Nuno_S=C3=A1?= , Cosmin Tanislav , Mihail Chindris , Rasmus Villemoes , Tomislav Denis , Marek Vasut , Olivier Moysan , Fabrice Gasnier , Lad Prabhakar , Dmitry Baryshkov , Marijn Suijten , Marius Cristea , Ibrahim Tilki , Jonathan Cameron Subject: [PATCH 01/13] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup. Date: Sun, 14 Jan 2024 17:19:57 +0000 Message-ID: <20240114172009.179893-2-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240114172009.179893-1-jic23@kernel.org> References: <20240114172009.179893-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron This allows the following struct fwnode_handle *child __free(kfree) = NULL; device_for_each_child_node(dev, child) { if (false) return -EINVAL; } without the fwnode_handle_put() call which tends to complicate early exits from such loops and lead to resource leak bugs. Can also be used where the fwnode_handle was obtained from a call such as fwnode_find_reference() as it will safely do nothing if IS_ERR() is true. Signed-off-by: Jonathan Cameron Reviewed-by: Andy Shevchenko --- v1: Thanks to Andy for reviewing the RFC. Add check for if (!IS_ERR_OR_NULL(_T)) to allow the compiler to optimize cases where it knows the passed in parameter is NULL or an error pointer. --- include/linux/property.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/property.h b/include/linux/property.h index 2b8f07fc68a9..9f3190d902ab 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -12,6 +12,7 @@ #include #include +#include #include #include #include @@ -161,6 +162,8 @@ struct fwnode_handle *device_get_named_child_node(const struct device *dev, struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode); void fwnode_handle_put(struct fwnode_handle *fwnode); +DEFINE_FREE(fwnode_handle, struct fwnode_handle *, + if (!IS_ERR_OR_NULL(_T)) fwnode_handle_put(_T)) int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index); int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const char *name);