From patchwork Wed Jan 28 11:58:58 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kenji Kaneshige X-Patchwork-Id: 4220 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n0SBxHgd031563 for ; Wed, 28 Jan 2009 11:59:17 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751866AbZA1L7Q (ORCPT ); Wed, 28 Jan 2009 06:59:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751910AbZA1L7Q (ORCPT ); Wed, 28 Jan 2009 06:59:16 -0500 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:37228 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbZA1L7P (ORCPT ); Wed, 28 Jan 2009 06:59:15 -0500 Received: from mt1.gw.fujitsu.co.jp ([10.0.50.74]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n0SBxDgG030190 (envelope-from kaneshige.kenji@jp.fujitsu.com); Wed, 28 Jan 2009 20:59:13 +0900 Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 886F445DE50; Wed, 28 Jan 2009 20:59:13 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 66B7345DE4F; Wed, 28 Jan 2009 20:59:13 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 4F2121DB803B; Wed, 28 Jan 2009 20:59:13 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.249.87.103]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 0E7721DB8037; Wed, 28 Jan 2009 20:59:13 +0900 (JST) Received: from ml13.css.fujitsu.com (ml13 [127.0.0.1]) by ml13.s.css.fujitsu.com (Postfix) with ESMTP id D3660FD0002; Wed, 28 Jan 2009 20:59:12 +0900 (JST) Received: from [127.0.0.1] (unknown [10.124.100.137]) by ml13.s.css.fujitsu.com (Postfix) with ESMTP id 4F5B0FD0001; Wed, 28 Jan 2009 20:59:12 +0900 (JST) Message-ID: <49804882.2060000@jp.fujitsu.com> Date: Wed, 28 Jan 2009 20:58:58 +0900 From: Kenji Kaneshige User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: linux-pci@vger.kernel.org, "Barnes, Jesse" CC: James Bottomley , Len Brown , linux-acpi@vger.kernel.org, linux-kernel , shaohua.li@intel.com, Grant Grundler Subject: [PATCH 7/8] PCI: fix wrong assumption in pci_get_interrupt_pin References: <1231604250.3642.33.camel@localhost.localdomain> <1231807693.27151.21.camel@localhost.localdomain> <1232046108.5966.57.camel@localhost.localdomain> <1232049269.5966.64.camel@localhost.localdomain> <1232050347.5966.66.camel@localhost.localdomain> <4970242C.4010404@jp.fujitsu.com> <1232115546.3224.5.camel@localhost.localdomain> <4973D2EE.3060203@jp.fujitsu.com> <1232328216.3247.68.camel@localhost.localdomain> <4973EF64.2050404@jp.fujitsu.com> <1232558780.736.24.camel@localhost.localdomain> <497D1BD7.9000609@jp.fujitsu.com> <498045D1.60005@jp.fujitsu.com> In-Reply-To: <498045D1.60005@jp.fujitsu.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Current pci_get_interrupt_pin() seems to have an assumption that pci_bus->self is NULL on the root pci bus. But it might not be true on some platforms. Because of this wrong assumption, current pci_get_interrupt_pin() might cause endless loop. We must check pci_bus->parent instead. Signed-off-by: Kenji Kaneshige --- drivers/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6.29-rc2/drivers/pci/pci.c =================================================================== --- linux-2.6.29-rc2.orig/drivers/pci/pci.c +++ linux-2.6.29-rc2/drivers/pci/pci.c @@ -1433,7 +1433,7 @@ pci_get_interrupt_pin(struct pci_dev *de if (!pin) return -1; - while (dev->bus->self) { + while (dev->bus->parent) { pin = pci_swizzle_interrupt_pin(dev, pin); dev = dev->bus->self; }