From patchwork Wed Apr 29 18:13:56 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 20782 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3TIFUtQ024978 for ; Wed, 29 Apr 2009 18:15:30 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755999AbZD2SNy (ORCPT ); Wed, 29 Apr 2009 14:13:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757213AbZD2SNy (ORCPT ); Wed, 29 Apr 2009 14:13:54 -0400 Received: from ausc60pc101.us.dell.com ([143.166.85.206]:50337 "EHLO ausc60pc101.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756689AbZD2SNx (ORCPT ); Wed, 29 Apr 2009 14:13:53 -0400 X-Loopcount0: from 10.9.160.254 Message-ID: <49F898E4.5080605@dell.com> Date: Wed, 29 Apr 2009 13:13:56 -0500 From: Mario Limonciello User-Agent: Thunderbird 2.0.0.21 (X11/20090409) MIME-Version: 1.0 To: Matthew Garrett CC: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Ignore garbage in dell-wmi events References: <49F73F92.9000201@dell.com> <20090429165517.GA32619@srcf.ucam.org> In-Reply-To: <20090429165517.GA32619@srcf.ucam.org> X-Enigmail-Version: 0.95.7 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Sure. Do you want me to resend all of them to add that? Matthew Garrett wrote: > Hi Mario, > > Can you add your signed-off-by: for this? > > Thanks, > Regards, Signed-off-by: Mario Limonciello --- --- a/drivers/platform/x86/dell-wmi.c~ 2009-04-28 12:32:32.000000000 -0500 +++ b/drivers/platform/x86/dell-wmi.c 2009-04-28 12:33:02.000000000 -0500 @@ -182,7 +182,7 @@ if (obj && obj->type == ACPI_TYPE_BUFFER) { int *buffer = (int *)obj->buffer.pointer; - key = dell_wmi_get_entry_by_scancode(buffer[1]); + key = dell_wmi_get_entry_by_scancode(0xFFFF & buffer[1]); if (key) { input_report_key(dell_wmi_input_dev, key->keycode, 1); input_sync(dell_wmi_input_dev); @@ -190,7 +190,7 @@ input_sync(dell_wmi_input_dev); } else printk(KERN_INFO "dell-wmi: Unknown key %x pressed\n", - buffer[1]); + 0xFFFF & buffer[1]); } }