From patchwork Fri Aug 26 00:34:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Huang, Ying" X-Patchwork-Id: 1099792 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7Q0YEpJ026246 for ; Fri, 26 Aug 2011 00:34:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292Ab1HZAeN (ORCPT ); Thu, 25 Aug 2011 20:34:13 -0400 Received: from mga09.intel.com ([134.134.136.24]:15629 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753073Ab1HZAeN (ORCPT ); Thu, 25 Aug 2011 20:34:13 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 25 Aug 2011 17:34:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,352,1309762800"; d="scan'208";a="42356075" Received: from yhuang-dev.sh.intel.com (HELO [10.239.13.105]) ([10.239.13.105]) by orsmga001.jf.intel.com with ESMTP; 25 Aug 2011 17:34:10 -0700 Message-ID: <4E56EA02.7020307@intel.com> Date: Fri, 26 Aug 2011 08:34:10 +0800 From: Huang Ying User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Iceowl/1.0b2 Icedove/3.1.11 MIME-Version: 1.0 To: "rick@microway.com" CC: Don Zickus , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Richard Houghton , ACPI Devel Mailing List , Len Brown , Matthew Garrett Subject: Re: kernel oops and panic in acpi_atomic_read under 2.6.39.3. call trace included References: <201108171751.51648.rick@microway.com> <8338f9871d1f52f9376a1eca319a7866.squirrel@www.microway.com> <201108222047.11086.rjw@sisk.pl> <201108221651.35654.rick@microway.com> <20110823171432.GA10794@redhat.com> <4E547B0F.6000001@intel.com> <7f348bab30fb6be7706ef35af999e5b1.squirrel@www.microway.com> In-Reply-To: <7f348bab30fb6be7706ef35af999e5b1.squirrel@www.microway.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 26 Aug 2011 00:34:15 +0000 (UTC) On 08/25/2011 11:47 PM, rick@microway.com wrote: > Hi Huang, > > My new setup reproduced the panic. However I do not have any gar accessed > messages on it. The gar mapped messages are in my previous email. Here > is the latest call trace. There is no GHES output prior to it: > That is wired. Can you try the patch attached? If my guessing is correct, there will be no panic, but something as follow will be in dmesg: ACPI atomic read mem: addr 0xxxxx mapped to 0 Best Regards, Huang Ying --- drivers/acpi/apei/ghes.c | 6 ++++++ drivers/acpi/atomicio.c | 4 ++++ 2 files changed, 10 insertions(+) --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -299,6 +299,9 @@ static struct ghes *ghes_new(struct acpi return ERR_PTR(-ENOMEM); ghes->generic = generic; rc = acpi_pre_map_gar(&generic->error_status_address); + pr_info(GHES_PFX "gar mapped: %d, 0x%llx\n", + generic->error_status_address.space_id, + generic->error_status_address.address); if (rc) goto err_free; error_block_length = generic->error_block_length; @@ -398,6 +401,9 @@ static int ghes_read_estatus(struct ghes u32 len; int rc; + pr_err(GHES_PFX "gar accessed: %d, 0x%llx\n", + g->error_status_address.space_id, + g->error_status_address.address); rc = acpi_atomic_read(&buf_paddr, &g->error_status_address); if (rc) { if (!silent && printk_ratelimit()) --- a/drivers/acpi/atomicio.c +++ b/drivers/acpi/atomicio.c @@ -270,6 +270,10 @@ static int acpi_atomic_read_mem(u64 padd rcu_read_lock(); addr = __acpi_ioremap_fast(paddr, width); + pr_err("ACPI atomic read mem: addr 0x%llx mapped to %p\n", + paddr, addr); + if (!addr) + return -EIO; switch (width) { case 8: *val = readb(addr);