From patchwork Mon Sep 5 02:50:04 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Huang, Ying" X-Patchwork-Id: 1124502 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p852iTG9022343 for ; Mon, 5 Sep 2011 02:50:08 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548Ab1IECuH (ORCPT ); Sun, 4 Sep 2011 22:50:07 -0400 Received: from mga11.intel.com ([192.55.52.93]:9760 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207Ab1IECuG (ORCPT ); Sun, 4 Sep 2011 22:50:06 -0400 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 04 Sep 2011 19:50:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.68,330,1312182000"; d="scan'208";a="48105841" Received: from yhuang-dev.sh.intel.com (HELO [10.239.13.105]) ([10.239.13.105]) by fmsmga001.fm.intel.com with ESMTP; 04 Sep 2011 19:50:04 -0700 Message-ID: <4E6438DC.4010007@intel.com> Date: Mon, 05 Sep 2011 10:50:04 +0800 From: Huang Ying User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.20) Gecko/20110820 Iceowl/1.0b2 Icedove/3.1.12 MIME-Version: 1.0 To: "rick@microway.com" CC: Don Zickus , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Richard Houghton , ACPI Devel Mailing List , Len Brown , Matthew Garrett Subject: Re: kernel oops and panic in acpi_atomic_read under 2.6.39.3. call trace included References: <201108171751.51648.rick@microway.com> <8338f9871d1f52f9376a1eca319a7866.squirrel@www.microway.com> <201108222047.11086.rjw@sisk.pl> <201108221651.35654.rick@microway.com> <20110823171432.GA10794@redhat.com> <4E547B0F.6000001@intel.com> <7f348bab30fb6be7706ef35af999e5b1.squirrel@www.microway.com> <4E56EA02.7020307@intel.com> <50815a5ec08cdb713de8eaa92ad6e8b3.squirrel@www.microway.com> In-Reply-To: <50815a5ec08cdb713de8eaa92ad6e8b3.squirrel@www.microway.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 05 Sep 2011 02:50:08 +0000 (UTC) On 09/03/2011 07:32 AM, rick@microway.com wrote: > Hi Huang, > > Sorry for the delay in my response. Hurricane Irene delayed our testing a > bit. > > I had to switch the 5620 CPUS I had for 5670s. After 4 days of running > (it was usually about 2 before) I finally got this output in dmesg: > > [337296.365930] GHES: gar accessed: 0, 0xbf7b9370 > [337296.365936] ACPI atomic read mem: addr 0xbf7b9370 mapped to > ffffc90013ee8370 > > It is not mapped to 0 as expected, but it didn't crash now! But I don't think this patch fixed the issue. Maybe just hided the issue. Do you have time to try the new patch attached? Best Regards, Huang Ying --- drivers/acpi/apei/ghes.c | 6 ++++++ drivers/acpi/atomicio.c | 2 ++ 2 files changed, 8 insertions(+) --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -299,6 +299,9 @@ static struct ghes *ghes_new(struct acpi return ERR_PTR(-ENOMEM); ghes->generic = generic; rc = acpi_pre_map_gar(&generic->error_status_address); + pr_info(GHES_PFX "gar mapped: %d, %#llx\n", + generic->error_status_address.space_id, + generic->error_status_address.address); if (rc) goto err_free; error_block_length = generic->error_block_length; @@ -398,6 +401,9 @@ static int ghes_read_estatus(struct ghes u32 len; int rc; + pr_err(GHES_PFX "gar accessed: %d, %#llx\n", + g->error_status_address.space_id, + g->error_status_address.address); rc = acpi_atomic_read(&buf_paddr, &g->error_status_address); if (rc) { if (!silent && printk_ratelimit()) --- a/drivers/acpi/atomicio.c +++ b/drivers/acpi/atomicio.c @@ -270,6 +270,8 @@ static int acpi_atomic_read_mem(u64 padd rcu_read_lock(); addr = __acpi_ioremap_fast(paddr, width); + if (!addr) + panic("ACPI atomic read mem: addr %#llx is not mapped!\n", paddr); switch (width) { case 8: *val = readb(addr);