From patchwork Tue Feb 10 19:16:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Darren Salt X-Patchwork-Id: 6509 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n1AJqEaH002613 for ; Tue, 10 Feb 2009 19:52:14 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754719AbZBJTwN (ORCPT ); Tue, 10 Feb 2009 14:52:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754676AbZBJTwN (ORCPT ); Tue, 10 Feb 2009 14:52:13 -0500 Received: from lon1-post-2.mail.demon.net ([195.173.77.149]:34200 "EHLO lon1-post-2.mail.demon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753795AbZBJTwK (ORCPT ); Tue, 10 Feb 2009 14:52:10 -0500 Received: from youmustbejoking.demon.co.uk ([80.176.152.238] helo=pentagram.youmustbejoking.demon.co.uk) by lon1-post-2.mail.demon.net with esmtp (Exim 4.69) id 1LWyeN-00008M-bY; Tue, 10 Feb 2009 19:52:08 +0000 Received: from [192.168.0.5] (helo=flibble.youmustbejoking.demon.co.uk) by pentagram.youmustbejoking.demon.co.uk with esmtp (Exim 4.63) (envelope-from ) id 1LWyeE-0007T5-MU; Tue, 10 Feb 2009 19:52:06 +0000 Date: Tue, 10 Feb 2009 19:16:27 +0000 From: Darren Salt To: Corentin Chary Cc: Matthew Garrett , Ingo Molnar , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Linus Torvalds , Andrew Morton , Jesse Barnes , Thomas Gleixner , "H. Peter Anvin" Message-ID: <5030FDE2BC%linux@youmustbejoking.demon.co.uk> In-Reply-To: <71cd59b00902100806s44f40812p441fae0b157cdb9c@mail.gmail.com> References: <20090209234911.GB862@elte.hu> <5030E21460%linux@youmustbejoking.demon.co.uk> <20090210150431.GA26798@srcf.ucam.org> <5030E7CFF4%linux@youmustbejoking.demon.co.uk> <20090210154533.GA27596@srcf.ucam.org> <71cd59b00902100806s44f40812p441fae0b157cdb9c@mail.gmail.com> Mail-Followup-To: Corentin Chary , Matthew Garrett , Ingo Molnar , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Linus Torvalds , Andrew Morton , Jesse Barnes , Thomas Gleixner , "H. Peter Anvin" , Darren Salt User-Agent: Gemini/2.29m (Qt/3.3.8b) (Linux-x86_64) X-SDate: Tue, 5642 Sep 1993 19:16:27 +0000 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.0.5 X-SA-Exim-Mail-From: linux@youmustbejoking.demon.co.uk X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on pentagram.youmustbejoking.demon.co.uk X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.2.5 Subject: Re: Oopses and ACPI problems (Linus 2.6.29-rc4) X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on pentagram.youmustbejoking.demon.co.uk) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org I demand that Corentin Chary may or may not have written... > On Tue, Feb 10, 2009 at 4:45 PM, Matthew Garrett > wrote: [snip; long delay when initialising eeepc-laptop] >>>> BIOS bug. There's an explicit delay in the eee bios for some reason, and >>>> I haven't found any straightforward way to avoid it. >>> BIOS bug or no, the fact remains that this is (AFAICS) a regression. >> You don't get properly working hotkeys otherwise, to the best of my >> recollection. There's an entry on the kernel bugzilla about this >> somewhere. > http://bugzilla.kernel.org/show_bug.cgi?id=12243 > If I understand things correctly, this was already the case before, but the > kernel boot was slower, so we couldn't see that. If it's not the case, > someone with a 901 should try bisecting (I only have a 701). I have some timings... From 2.6.28.4: [ 0.898903] eeepc: Eee PC Hotkey Driver [ 0.902414] eeepc: Hotkey init (getting ACPI bus status) [ 0.905913] eeepc: Hotkey init (init flags) [ 2.620193] eeepc: Hotkey init flags 0x41 [ 2.626667] eeepc: Get control methods supported: 0x101713 [ 2.630215] input: Asus EeePC extra buttons as /class/input/input4 From 2.6.29-rc4: [ 2.141971] eeepc: Eee PC Hotkey Driver [ 2.145325] eeepc: Hotkey init (getting ACPI bus status) [ 2.148555] eeepc: Hotkey init (init flags) [ 2.286445] usb 5-1: new full speed USB device using uhci_hcd and address 2 [... USB Bluetooth device; Elantech test ...] [ 2.780187] input: ETPS/2 Elantech Touchpad as /class/input/input5 [ 28.088399] eeepc: Hotkey init flags 0x41 [ 28.094880] eeepc: Get control methods supported: 0x101713 [ 28.098425] input: Asus EeePC extra buttons as /class/input/input6 Config is as in my first posting in this thread; kernel logs are attached. The following patch is applied: --- ./drivers/platform/x86/eeepc-laptop.c~ 2009-02-10 16:40:18.000000000 +0000 +++ ./drivers/platform/x86/eeepc-laptop.c 2009-02-10 16:40:18.000000000 +0000 @@ -452,10 +452,15 @@ struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL }; int result; + printk(EEEPC_NOTICE "Hotkey init (getting ACPI bus status)\n"); result = acpi_bus_get_status(ehotk->device); if (result) + { + printk(EEEPC_ERR "Hotkey init aborted (%d)\n", result); return result; + } if (ehotk->device->status.present) { + printk(EEEPC_NOTICE "Hotkey init (init flags)\n"); if (write_acpi_int(ehotk->handle, "INIT", ehotk->init_flag, &buffer)) { printk(EEEPC_ERR "Hotkey initialization failed\n");