From patchwork Thu Jan 31 03:15:19 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yasuaki Ishimatsu X-Patchwork-Id: 2070651 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 270C4DF2A1 for ; Thu, 31 Jan 2013 03:15:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756567Ab3AaDPl (ORCPT ); Wed, 30 Jan 2013 22:15:41 -0500 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:58016 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756523Ab3AaDPk (ORCPT ); Wed, 30 Jan 2013 22:15:40 -0500 Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 2025F3EE0AE; Thu, 31 Jan 2013 12:15:39 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 0613F45DEB7; Thu, 31 Jan 2013 12:15:39 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id E103945DEB6; Thu, 31 Jan 2013 12:15:38 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id AFFC71DB803C; Thu, 31 Jan 2013 12:15:38 +0900 (JST) Received: from G01JPEXCHYT22.g01.fujitsu.local (G01JPEXCHYT22.g01.fujitsu.local [10.128.193.105]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 2AE53E18003; Thu, 31 Jan 2013 12:15:38 +0900 (JST) Received: from [127.0.0.1] (10.124.101.33) by G01JPEXCHYT22.g01.fujitsu.local (10.128.193.105) with Microsoft SMTP Server id 14.2.309.2; Thu, 31 Jan 2013 12:15:33 +0900 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.7.4 Message-ID: <5109E1C7.5020702@jp.fujitsu.com> Date: Thu, 31 Jan 2013 12:15:19 +0900 From: Yasuaki Ishimatsu User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: "Rafael J. Wysocki" , ACPI Devel Maling List , LKML , Mika Westerberg , Yinghai Lu , Toshi Kani Subject: Re: [PATCH 0/4] Fix acpi_bus_get_device() check References: <1451967.YMyGeCCNtu@vostro.rjw.lan> <6099377.PFvsxPeyib@vostro.rjw.lan> <5109E11A.5030400@jp.fujitsu.com> In-Reply-To: <5109E11A.5030400@jp.fujitsu.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_SUCCESS() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu --- drivers/acpi/dock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-pm/drivers/acpi/dock.c =================================================================== --- linux-pm.orig/drivers/acpi/dock.c 2013-01-31 11:39:40.574849906 +0900 +++ linux-pm/drivers/acpi/dock.c 2013-01-31 11:50:11.329850213 +0900 @@ -836,7 +836,7 @@ static ssize_t show_docked(struct device struct dock_station *dock_station = dev->platform_data; - if (ACPI_SUCCESS(acpi_bus_get_device(dock_station->handle, &tmp))) + if (!acpi_bus_get_device(dock_station->handle, &tmp)) return snprintf(buf, PAGE_SIZE, "1\n"); return snprintf(buf, PAGE_SIZE, "0\n"); }