From patchwork Wed Nov 6 01:18:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Lu X-Patchwork-Id: 3144581 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AFE409F3C4 for ; Wed, 6 Nov 2013 01:17:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B0BEA205C6 for ; Wed, 6 Nov 2013 01:17:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B651C205BB for ; Wed, 6 Nov 2013 01:17:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755636Ab3KFBRe (ORCPT ); Tue, 5 Nov 2013 20:17:34 -0500 Received: from mga11.intel.com ([192.55.52.93]:13369 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755582Ab3KFBRd (ORCPT ); Tue, 5 Nov 2013 20:17:33 -0500 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 05 Nov 2013 17:17:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,643,1378882800"; d="scan'208";a="428497235" Received: from aaronlu.sh.intel.com ([10.239.37.146]) by fmsmga002.fm.intel.com with ESMTP; 05 Nov 2013 17:17:30 -0800 Message-ID: <527998D8.2030809@intel.com> Date: Wed, 06 Nov 2013 09:18:16 +0800 From: Aaron Lu Organization: Intel, Shanghai, PRC MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: ACPI Devel Mailing List , Kirill Tkhai Subject: Re: [PATCH 2/2] ACPI / video: Quirk initial backlight level 0 References: <52799553.7020406@intel.com> <5279963E.8030109@intel.com> In-Reply-To: <5279963E.8030109@intel.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 11/06/2013 09:07 AM, Aaron Lu wrote: > Some firmware doesn't initialize initial backlight level to a proper > value and _BQC will return 0 on first time evaluation. We used to be > able to detect such incorrect value with our code logic, as value 0 > normally isn't a valid value in _BCL. But with the introduction of Win8, > firmware begins to fill _BCL with values from 0 to 100, now 0 becomes > a valid value but that value will make user's screen black. This patch > test initial _BQC for value 0, if such a value is returned, do not use > it. > > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=64031 > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=61231 > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=63111 > Reported-by: Qingshuai Tian > Tested-by: Aaron Lu on "Idealpad u330p" > Reported-and-tested-by: on "Acer Aspire V5-573G" > Reported-and-tested-by: Kirill Tkhai on "HP 250 G1" With this patch applied, we do not need commit e37f14a5fb85 "ACPI / video: Ignore BIOS initial backlight value for HP 250 G1" any more. So I made a revert patch on top of the two. From: Aaron Lu Subject: [PATCH] Revert "ACPI / video: Ignore BIOS initial backlight value for HP 250 G1" This reverts commit e37f14a5fb85522f3bbf88ece6134c4e610ed598. It turned out other systems also share the same problem with bug 63111 so I made a patch to catch initial brightness level 0 problem. With that patch applied, we do not need to place HP 250 G1 in DMI table. Signed-off-by: Aaron Lu --- drivers/acpi/video.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index a049fa9360d0..18dbdff4656e 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -504,14 +504,6 @@ static struct dmi_system_id video_dmi_table[] __initdata = { DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion m4 Notebook PC"), }, }, - { - .callback = video_ignore_initial_backlight, - .ident = "HP 250 G1", - .matches = { - DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), - DMI_MATCH(DMI_PRODUCT_NAME, "HP 250 G1 Notebook PC"), - }, - }, {} };