From patchwork Sun May 17 07:38:46 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Berger X-Patchwork-Id: 24288 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n4H7dDsn008491 for ; Sun, 17 May 2009 07:39:14 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752369AbZEQHi6 (ORCPT ); Sun, 17 May 2009 03:38:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751779AbZEQHi6 (ORCPT ); Sun, 17 May 2009 03:38:58 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:60319 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752576AbZEQHi5 (ORCPT ); Sun, 17 May 2009 03:38:57 -0400 Received: from smtp5-g21.free.fr (localhost [127.0.0.1]) by smtp5-g21.free.fr (Postfix) with ESMTP id C9DA8D480BB; Sun, 17 May 2009 09:38:50 +0200 (CEST) Received: from asustour (mag77-1-82-238-14-130.fbx.proxad.net [82.238.14.130]) by smtp5-g21.free.fr (Postfix) with ESMTP id D6DC0D480DD; Sun, 17 May 2009 09:38:46 +0200 (CEST) Received: from olivier by asustour with local (Exim 4.69) (envelope-from ) id 1M5axK-0007yE-92; Sun, 17 May 2009 09:38:46 +0200 From: Olivier Berger To: Len Brown Cc: Thomas Renninger , linux-acpi@vger.kernel.org Subject: Re: Incorrect ACPI blacklisting of ASUS P4B266 ? References: <87k5691x3y.fsf@olivierberger.com> <200904281339.15689.trenn@suse.de> <877i14aed8.fsf@olivierberger.com> <200904281956.50640.trenn@suse.de> X-Face: TFGE)@^4_IaB6~n%L%Uwg:5+=,p`YM; OkHKW*Td2F@X1Yh*<&fpT.8 ,&k"Fi:,cX!4[,s3&kF')/@nil%|&4S#K_G;)HPeb7@$P#J_-ap~1ppSw5RQf Date: Sun, 17 May 2009 09:38:46 +0200 In-Reply-To: (Len Brown's message of "Thu\, 14 May 2009 13\:14\:29 -0400 \(EDT\)") Message-ID: <87ws8gfabd.fsf@olivierberger.com> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi. Len Brown writes: > The P4B266 DMI entry went into ./arch/i386/kernel/dmi_scan.c > back in Aug-2003. Wow, I understand why it was hard to track it back to the time it was included ;-) > > That was when I was just starting to maintain ACPI, > and I took a bunch of blacklist entries from SuSE > because they were already shipping with ACPI enabled. > > In the short term, it may have been the right thing to do, > but in the long term it was a mistake and I regret doing it. > > Blacklist entries paper-over real bugs, and unless we are lucky > enough that somebody like you, Oliver, steps forward, > blacklist entries are nearly impossible to ever remove. > > So I'm inclined to apply your original patch to delete > the blacklist entry entirely. If somebody with one of > those boxes has a regression, we'll go fix their box -- > which we may have acutally fixed years ago and not known it... > OK, as a maintainer you'll be the one to blame ;) And as a user, I'll be glad to see my system fully using ACPI, I guess :-) Len Brown writes: > Olivier, > If you can send me a properly formatted patch > to remove the dmi entry, > (Documentation/SubmittingPatches) > including your signed-off, i'll apply it. Here's it in attachment. I'm not really experienced with git so I hope it suits your needs. > > thanks, > Len Brown, Intel Open Source Technology Center > > Best regards, - -- Olivier BERGER (OpenPGP: 1024D/B4C5F37F) http://www.olivierberger.com/weblog/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Processed by Mailcrypt 3.5.8+ iD8DBQFKD77rLBigKrTF838RAthrAKDerhUKv8JZTvtJ5SrlooeFZofU0wCgyJ8L 8z1I6OP9wSsS7JQn7vm1UIc= =AQyP -----END PGP SIGNATURE----- From 6f304fa7c0e0c5bac86fb47c53354889017fceb8 Mon Sep 17 00:00:00 2001 From: olivier Date: Sat, 16 May 2009 15:47:18 +0200 Subject: [PATCH] Removing ACPI blacklisting for P4B266 mainboards. See http://marc.info/?l=linux-acpi&m=124068823904429&w=2 for discussion Signed-off-by: Olivier Berger --- arch/x86/kernel/acpi/boot.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index 723989d..065b3fa 100644 --- a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c @@ -1569,14 +1569,6 @@ static struct dmi_system_id __initdata acpi_dmi_table[] = { }, { .callback = force_acpi_ht, - .ident = "ASUS P4B266", - .matches = { - DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."), - DMI_MATCH(DMI_BOARD_NAME, "P4B266"), - }, - }, - { - .callback = force_acpi_ht, .ident = "ASUS P2B-DS", .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."), -- 1.6.2.4