From patchwork Sat Feb 7 06:41:31 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Len Brown X-Patchwork-Id: 6000 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n176gAeE018927 for ; Sat, 7 Feb 2009 06:42:11 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752064AbZBGGmK (ORCPT ); Sat, 7 Feb 2009 01:42:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752838AbZBGGmK (ORCPT ); Sat, 7 Feb 2009 01:42:10 -0500 Received: from vms173019pub.verizon.net ([206.46.173.19]:22518 "EHLO vms173019pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795AbZBGGmD (ORCPT ); Sat, 7 Feb 2009 01:42:03 -0500 Received: from localhost.localdomain ([96.237.168.40]) by vms173019.mailsrvcs.net (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 32bit)) with ESMTPA id <0KEO00ELZNY0GHP2@vms173019.mailsrvcs.net> for linux-acpi@vger.kernel.org; Sat, 07 Feb 2009 00:42:01 -0600 (CST) Received: from localhost.localdomain (d975xbx2 [127.0.0.1]) by localhost.localdomain (8.14.2/8.14.2) with ESMTP id n176fxjg009898; Sat, 07 Feb 2009 01:41:59 -0500 Received: (from lenb@localhost) by localhost.localdomain (8.14.2/8.14.2/Submit) id n176fxwK009897; Sat, 07 Feb 2009 01:41:59 -0500 From: Len Brown To: linux-acpi@vger.kernel.org Cc: Len Brown Subject: [PATCH 23/30] ACPI: disable ACPI cleanly when bad RSDP found Date: Sat, 07 Feb 2009 01:41:31 -0500 Message-id: <9e3a9d1ed8cc8db93e5c53e9a5b09065bd95de8b.1233988826.git.len.brown@intel.com> X-Mailer: git-send-email 1.6.1.2.390.gba743 In-reply-to: <091d71e023557136e96f0e54f301497a3fc95dc3.1233988822.git.len.brown@intel.com> References: <091d71e023557136e96f0e54f301497a3fc95dc3.1233988822.git.len.brown@intel.com> In-reply-to: <091d71e023557136e96f0e54f301497a3fc95dc3.1233988822.git.len.brown@intel.com> References: <091d71e023557136e96f0e54f301497a3fc95dc3.1233988822.git.len.brown@intel.com> Organization: Intel Open Source Technology Center Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Len Brown When ACPI is disabled in the BIOS of this VIA C3 box, it invalidates the RSDP, which Linux notices: ACPI Error (tbxfroot-0218): A valid RSDP was not found [20080926] Bug Linux neglected to disable ACPI at that stage, and later scribbled on smp_found_config: ACPI: No APIC-table, disabling MPS But this box doesn't run well in legacy PIC mode, it needed IOAPIC mode to perform correctly: http://lkml.org/lkml/2009/2/5/39 So exit ACPI mode cleanly when we first detect that it is hopeless. Signed-off-by: Len Brown --- drivers/acpi/tables.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index 775c97a..a885295 100644 --- a/drivers/acpi/tables.c +++ b/drivers/acpi/tables.c @@ -293,7 +293,12 @@ static void __init check_multiple_madt(void) int __init acpi_table_init(void) { - acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0); + acpi_status status; + + status = acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0); + if (ACPI_FAILURE(status)) + return 1; + check_multiple_madt(); return 0; }