| Message ID | 9f132652d94c96476b0b0a8caf0c10e96ab10fa8.1341032550.git.len.brown@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, 30 Jun 2012, Len Brown wrote: > From: Pavel Vasilyev <pavel@pavlinux.ru> > > Current code is ignoring the last character of "enable" and "disable" > in comparisons. > > https://bugzilla.kernel.org/show_bug.cgi?id=33732 > > Signed-off-by: Len Brown <len.brown@intel.com> > --- > drivers/acpi/sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c > index 9f66181..240a244 100644 > --- a/drivers/acpi/sysfs.c > +++ b/drivers/acpi/sysfs.c > @@ -173,7 +173,7 @@ static int param_set_trace_state(const char *val, struct kernel_param *kp) > { > int result = 0; > > - if (!strncmp(val, "enable", strlen("enable") - 1)) { > + if (!strncmp(val, "enable", strlen("enable"))) { Ironically, this is the less efficient of two possible fixes. It would have been better to leave the "- 1" in place and change strlen to sizeof. That's probably what the original author had in mind. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c index 9f66181..240a244 100644 --- a/drivers/acpi/sysfs.c +++ b/drivers/acpi/sysfs.c @@ -173,7 +173,7 @@ static int param_set_trace_state(const char *val, struct kernel_param *kp) { int result = 0; - if (!strncmp(val, "enable", strlen("enable") - 1)) { + if (!strncmp(val, "enable", strlen("enable"))) { result = acpi_debug_trace(trace_method_name, trace_debug_level, trace_debug_layer, 0); if (result) @@ -181,7 +181,7 @@ static int param_set_trace_state(const char *val, struct kernel_param *kp) goto exit; } - if (!strncmp(val, "disable", strlen("disable") - 1)) { + if (!strncmp(val, "disable", strlen("disable"))) { int name = 0; result = acpi_debug_trace((char *)&name, trace_debug_level, trace_debug_layer, 0);