From patchwork Fri Sep 25 16:41:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 7266601 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AA5E59F30C for ; Fri, 25 Sep 2015 16:43:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CFEBF20942 for ; Fri, 25 Sep 2015 16:43:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E713D2093F for ; Fri, 25 Sep 2015 16:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932698AbbIYQmk (ORCPT ); Fri, 25 Sep 2015 12:42:40 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:34218 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932498AbbIYQmH (ORCPT ); Fri, 25 Sep 2015 12:42:07 -0400 Received: by padhy16 with SMTP id hy16so110400439pad.1 for ; Fri, 25 Sep 2015 09:42:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Lip0XQpIhzfkEtjTNizVw4b9OMx/IlPdPwC9RW55Nf4=; b=VGzdjg0gn793lzHIb2km5JesCb0M6mdUgVCGuwEQOTdFJj3iuJCi2ocp7CQWBgyYBf IDiBfVkmcGWzklyKjrKd+zodQoIrzuKYa6OwbgJnGoeLNPUYJ9L+XPbYO+ob/g+JRKE0 6jDzgK7fVHp3J8h79u4jJfq29Nave1P1a8V9skCea/osdAMrH+8xNWXRbUPDaU/R40Bi SIaZUqGuNZcL72Brmsni1PwDYcXoUTAAa5D9w/OpFtJmvSSaBali/zUUn5Esy8/DRHxX LN66e90aaPdl24Ef/iC2WJoH2a8rLn6L3gSIHFT9qO9/cgvM10FWHD5NPhMNh5PS11TN 69hw== X-Gm-Message-State: ALoCoQmwzNBScXY5vt7e/NLOPwaisNYf5P5Vbqao5iBcKlu/7S2h0Ad2EAg58MWPthQ/tQPJ2WcW X-Received: by 10.69.1.67 with SMTP id be3mr8609738pbd.78.1443199326338; Fri, 25 Sep 2015 09:42:06 -0700 (PDT) Received: from localhost ([70.35.39.2]) by smtp.gmail.com with ESMTPSA id ll9sm4797436pbc.42.2015.09.25.09.42.05 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 25 Sep 2015 09:42:05 -0700 (PDT) From: Viresh Kumar To: Greg Kroah-Hartman Cc: linaro-kernel@lists.linaro.org, QCA ath9k Development , Intel Linux Wireless , Viresh Kumar , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-bluetooth@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-edac@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org Subject: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Date: Fri, 25 Sep 2015 09:41:37 -0700 Message-Id: X-Mailer: git-send-email 2.4.0 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big endian 64 bit systems. There are no such platforms yet, but the code needs to be robust for such a case. Fix that by passing a local variable to debugfs_create_bool() and assigning its value to global_lock later. Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki --- V3->V4: - Create a local variable instead of changing type of global_lock (Rafael) - Drop the stable tag - BCC'd a lot of people (rather than cc'ing them) to make sure - the series reaches them - mailing lists do not block the patchset due to long cc list - and we don't spam the BCC'd people for every reply --- drivers/acpi/ec_sys.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c index b4c216bab22b..b44b91331a56 100644 --- a/drivers/acpi/ec_sys.c +++ b/drivers/acpi/ec_sys.c @@ -110,6 +110,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) struct dentry *dev_dir; char name[64]; umode_t mode = 0400; + u32 val; if (ec_device_count == 0) { acpi_ec_debugfs_dir = debugfs_create_dir("ec", NULL); @@ -127,10 +128,11 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe)) goto error; - if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, - (u32 *)&first_ec->global_lock)) + if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, &val)) goto error; + first_ec->global_lock = val; + if (write_support) mode = 0600; if (!debugfs_create_file("io", mode, dev_dir, ec, &acpi_ec_io_ops))