| Message ID | f23da383a8fdbee15acd41fdcd38ef3a89045a43.1709780590.git.haibo1.xu@intel.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add ACPI NUMA support for RISC-V | expand |
On Thu, Mar 7, 2024, at 09:47, Haibo Xu wrote: > x86/arm64/loongarch would select ACPI_NUMA by default and riscv > would do the same thing, so the dependency is no longer needed > since these are the four architectures that support ACPI. > > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Suggested-by: Sunil V L <sunilvl@ventanamicro.com> > Signed-off-by: Haibo Xu <haibo1.xu@intel.com> > --- > drivers/acpi/numa/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/acpi/numa/Kconfig b/drivers/acpi/numa/Kconfig > index 849c2bd820b9..2bf47ad1ec9b 100644 > --- a/drivers/acpi/numa/Kconfig > +++ b/drivers/acpi/numa/Kconfig > @@ -2,7 +2,6 @@ > config ACPI_NUMA > bool "NUMA support" > depends on NUMA > - depends on (X86 || ARM64 || LOONGARCH) > default y if ARM64 Can we remove the prompt as well and make this a hidden option? I think this is now always selected when it can be used anyway. If we make it def_bool NUMA && !X86 then the select statements except for the X86_64_ACPI_NUMA can also go away. Arnd
On Thu, Mar 7, 2024 at 4:44 PM Arnd Bergmann <arnd@arndb.de> wrote: > > On Thu, Mar 7, 2024, at 09:47, Haibo Xu wrote: > > x86/arm64/loongarch would select ACPI_NUMA by default and riscv > > would do the same thing, so the dependency is no longer needed > > since these are the four architectures that support ACPI. > > > > Suggested-by: Arnd Bergmann <arnd@arndb.de> > > Suggested-by: Sunil V L <sunilvl@ventanamicro.com> > > Signed-off-by: Haibo Xu <haibo1.xu@intel.com> > > --- > > drivers/acpi/numa/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/acpi/numa/Kconfig b/drivers/acpi/numa/Kconfig > > index 849c2bd820b9..2bf47ad1ec9b 100644 > > --- a/drivers/acpi/numa/Kconfig > > +++ b/drivers/acpi/numa/Kconfig > > @@ -2,7 +2,6 @@ > > config ACPI_NUMA > > bool "NUMA support" > > depends on NUMA > > - depends on (X86 || ARM64 || LOONGARCH) > > default y if ARM64 > > Can we remove the prompt as well and make this a > hidden option? I think this is now always selected > when it can be used anyway. > > If we make it > > def_bool NUMA && !X86 > > then the select statements except for the X86_64_ACPI_NUMA > can also go away. > Good idea! Shall we include the ACPI in the def_bool definition? > Arnd
On Thu, Mar 7, 2024, at 10:19, Haibo Xu wrote: > On Thu, Mar 7, 2024 at 4:44 PM Arnd Bergmann <arnd@arndb.de> wrote: >> On Thu, Mar 7, 2024, at 09:47, Haibo Xu wrote: >> If we make it >> >> def_bool NUMA && !X86 >> >> then the select statements except for the X86_64_ACPI_NUMA >> can also go away. >> > > Good idea! > Shall we include the ACPI in the def_bool definition? > No need, because this is inside of an 'if ACPI' block. Arnd
On Thu, Mar 7, 2024 at 5:23 PM Arnd Bergmann <arnd@arndb.de> wrote: > > On Thu, Mar 7, 2024, at 10:19, Haibo Xu wrote: > > On Thu, Mar 7, 2024 at 4:44 PM Arnd Bergmann <arnd@arndb.de> wrote: > >> On Thu, Mar 7, 2024, at 09:47, Haibo Xu wrote: > > >> If we make it > >> > >> def_bool NUMA && !X86 > >> > >> then the select statements except for the X86_64_ACPI_NUMA > >> can also go away. > >> > > > > Good idea! > > Shall we include the ACPI in the def_bool definition? > > > > No need, because this is inside of an 'if ACPI' block. > Cool! Let me have a try. Thanks, Haibo > Arnd
diff --git a/drivers/acpi/numa/Kconfig b/drivers/acpi/numa/Kconfig index 849c2bd820b9..2bf47ad1ec9b 100644 --- a/drivers/acpi/numa/Kconfig +++ b/drivers/acpi/numa/Kconfig @@ -2,7 +2,6 @@ config ACPI_NUMA bool "NUMA support" depends on NUMA - depends on (X86 || ARM64 || LOONGARCH) default y if ARM64 config ACPI_HMAT
x86/arm64/loongarch would select ACPI_NUMA by default and riscv would do the same thing, so the dependency is no longer needed since these are the four architectures that support ACPI. Suggested-by: Arnd Bergmann <arnd@arndb.de> Suggested-by: Sunil V L <sunilvl@ventanamicro.com> Signed-off-by: Haibo Xu <haibo1.xu@intel.com> --- drivers/acpi/numa/Kconfig | 1 - 1 file changed, 1 deletion(-)