| Message ID | 20200915121912.4347-1-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: panel: add support for TDO tl070wsh30 panel | expand |
Hi Sam, Is there anything more to change ? Thanks, Neil On 15/09/2020 14:19, Neil Armstrong wrote: > This adds support bindings and support for the TDO TL070WSH30 TFT-LCD panel > module shipped with the Amlogic S400 Development Kit. > The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. > It provides a MIPI DSI interface to the host, a built-in LED backlight > and touch controller. > > Changes since v3 at [3]: > - reordered tdo vendor prefix > > Changes since v2 at [2]: > - added reset gpio to panel-simple-dsi bindings > - moved bindings to panel-simple > - re-ordered prepare/unprepare > - added back refresh print > - moved regulator/reset handling in prepare/unprepare > - aligned remove/shutdown with panel-simple > - added sentinel comment into dt match table > > Changes since v1 at [1]: > - added missing vendor-prefixes patch > - removed vrefresh > - fixed warning on add_panel return > - removed DRM logging > > [1] https://patchwork.freedesktop.org/series/81376/#rev1 > [2] https://patchwork.freedesktop.org/series/81376/#rev2 > [3] https://patchwork.freedesktop.org/series/81376/#rev3 > > Neil Armstrong (4): > dt-bindings: vendor-prefixes: Add Shanghai Top Display > Optolelectronics vendor prefix > dt-bindings: display: panel-simple-dsi: add optional reset gpio > dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel > bindings > drm: panel: add TDO tl070wsh30 panel driver > > .../display/panel/panel-simple-dsi.yaml | 3 + > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > drivers/gpu/drm/panel/Kconfig | 11 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 250 ++++++++++++++++++ > 5 files changed, 267 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c >
Hi Neil. On Tue, Sep 29, 2020 at 11:25:17AM +0200, Neil Armstrong wrote: > Hi Sam, > > Is there anything more to change ? Sorry for taking so long to get back to you on this. All patches looks good and are: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> I assume you will apply the patches. Sam
On 17/10/2020 08:08, Sam Ravnborg wrote: > Hi Neil. > > On Tue, Sep 29, 2020 at 11:25:17AM +0200, Neil Armstrong wrote: >> Hi Sam, >> >> Is there anything more to change ? > Sorry for taking so long to get back to you on this. > > All patches looks good and are: > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > > I assume you will apply the patches. Indeed, Thanks ! Applying to drm-misc-next > > Sam >
This adds support bindings and support for the TDO TL070WSH30 TFT-LCD panel module shipped with the Amlogic S400 Development Kit. The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. It provides a MIPI DSI interface to the host, a built-in LED backlight and touch controller. Changes since v3 at [3]: - reordered tdo vendor prefix Changes since v2 at [2]: - added reset gpio to panel-simple-dsi bindings - moved bindings to panel-simple - re-ordered prepare/unprepare - added back refresh print - moved regulator/reset handling in prepare/unprepare - aligned remove/shutdown with panel-simple - added sentinel comment into dt match table Changes since v1 at [1]: - added missing vendor-prefixes patch - removed vrefresh - fixed warning on add_panel return - removed DRM logging [1] https://patchwork.freedesktop.org/series/81376/#rev1 [2] https://patchwork.freedesktop.org/series/81376/#rev2 [3] https://patchwork.freedesktop.org/series/81376/#rev3 Neil Armstrong (4): dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix dt-bindings: display: panel-simple-dsi: add optional reset gpio dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel bindings drm: panel: add TDO tl070wsh30 panel driver .../display/panel/panel-simple-dsi.yaml | 3 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 250 ++++++++++++++++++ 5 files changed, 267 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c