| Message ID | 20211112162827.128319-1-aouledameur@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | usb: meson: fix shared reset control use | expand |
Amjad Ouled-Ameur <aouledameur@baylibre.com> writes: > This patchset fixes a usb suspend warning seen on the libretech-cc by > using reset_control_rearm() call of the reset framework API. > This call allows a reset consummer to release the reset line even when > just triggered so that it may be triggered again by other reset > consummers. > > reset_control_(de)assert() calls are called, in some meson usb drivers, > on a shared reset line when reset_control_reset has been used. This is not > allowed by the reset framework. > > Finally the meson usb drivers are updated to use this new call, which > solves the suspend issue addressed by the previous reverted > commit 7a410953d1fb ("usb: dwc3: meson-g12a: fix shared reset control > use"). Tested-by: Kevin Hilman <khilman@baylibre.com> Tested suspend/resume on Khadas VIM3 and confirmed that the reset warnings are gone. Kevin
This patchset fixes a usb suspend warning seen on the libretech-cc by using reset_control_rearm() call of the reset framework API. This call allows a reset consummer to release the reset line even when just triggered so that it may be triggered again by other reset consummers. reset_control_(de)assert() calls are called, in some meson usb drivers, on a shared reset line when reset_control_reset has been used. This is not allowed by the reset framework. Finally the meson usb drivers are updated to use this new call, which solves the suspend issue addressed by the previous reverted commit 7a410953d1fb ("usb: dwc3: meson-g12a: fix shared reset control use"). changes since v2 [0]: - Rebased on latest master [0]: https://lore.kernel.org/all/20201201190100.17831-1-aouledameur@baylib re.com/ Amjad Ouled-Ameur (3): phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use usb: dwc3: meson-g12a: fix shared reset control use phy: amlogic: meson8b-usb2: fix shared reset control use drivers/phy/amlogic/phy-meson-gxl-usb2.c | 5 ++++- drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++++ drivers/usb/dwc3/dwc3-meson-g12a.c | 17 ++++++++++++----- 3 files changed, 20 insertions(+), 6 deletions(-)