mbox series

[0/2] Add IRQ check to the Meson MMC/SD drivers

Message ID 20211217202717.10041-1-s.shtylyov@omp.ru (mailing list archive)
Headers show
Series Add IRQ check to the Meson MMC/SD drivers | expand

Message

Sergey Shtylyov Dec. 17, 2021, 8:27 p.m. UTC 
Here are 2 patches against the 'fixes' branch of Ulf Hansson's 'mmc.git' repo.
The affected drivers call platform_get_irq() but forget to check for the error
case and blithely pass the negative error codes to devm_request_threaded_irq()
(which takes *unsigned* IRQ #). Now stop calling devm_request_threaded_irq()
with the invalid IRQ #s!

Sergey Shtylyov (2):
  mmc: meson-mx-sdhc: add IRQ check
  mmc: meson-mx-sdio: add IRQ check

 drivers/mmc/host/meson-mx-sdhc-mmc.c | 5 +++++
 drivers/mmc/host/meson-mx-sdio.c     | 5 +++++
 2 files changed, 10 insertions(+)

Comments

Ulf Hansson Dec. 21, 2021, 1:03 p.m. UTC | #1 
On Fri, 17 Dec 2021 at 21:27, Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>
> Here are 2 patches against the 'fixes' branch of Ulf Hansson's 'mmc.git' repo.
> The affected drivers call platform_get_irq() but forget to check for the error
> case and blithely pass the negative error codes to devm_request_threaded_irq()
> (which takes *unsigned* IRQ #). Now stop calling devm_request_threaded_irq()
> with the invalid IRQ #s!
>
> Sergey Shtylyov (2):
>   mmc: meson-mx-sdhc: add IRQ check
>   mmc: meson-mx-sdio: add IRQ check
>
>  drivers/mmc/host/meson-mx-sdhc-mmc.c | 5 +++++
>  drivers/mmc/host/meson-mx-sdio.c     | 5 +++++
>  2 files changed, 10 insertions(+)
>

Applied for next, thanks!

Kind regards
Uffe