| Message ID | 20230621062715.455652-1-gnstark@sberdevices.ru (mailing list archive) |
|---|---|
| Headers | show |
| Series | meson saradc: add iio channels to read channel 7 mux inputs | expand |
On Wed, Jun 21, 2023 at 09:26:07AM +0300, George Stark wrote: > From: George Stark <GNStark@sberdevices.ru> > > In meson saradc channel7 is connected to muxer which allows to measure > inner sources like Vdd, GND, several Vdd dividers. This patch series > adds independent iio channel (with label) for every chan7 mux input. > Mux switch is handled transparent for clients. > This functionality can help debug\test\calibrate adc. > This code is relevant for all supported amlogic soc families Code wise looks good to me, some remarks about commit messages and comments. > This patch series was created after discussion [1], [2] > > [1] https://lore.kernel.org/lkml/20230524000111.14370-1-gnstark@sberdevices.ru/ > [2] https://lore.kernel.org/lkml/20230527214854.126517-1-gnstark@sberdevices.ru/
From: George Stark <GNStark@sberdevices.ru> In meson saradc channel7 is connected to muxer which allows to measure inner sources like Vdd, GND, several Vdd dividers. This patch series adds independent iio channel (with label) for every chan7 mux input. Mux switch is handled transparent for clients. This functionality can help debug\test\calibrate adc. This code is relevant for all supported amlogic soc families This patch series was created after discussion [1], [2] [1] https://lore.kernel.org/lkml/20230524000111.14370-1-gnstark@sberdevices.ru/ [2] https://lore.kernel.org/lkml/20230527214854.126517-1-gnstark@sberdevices.ru/ George Stark (3): meson saradc: code refactoring meson saradc: add channel labels meson saradc: support reading from channel7 mux inputs drivers/iio/adc/meson_saradc.c | 165 +++++++++++++++++++++++---------- 1 file changed, 115 insertions(+), 50 deletions(-)