| Message ID | 20230815092751.1791195-1-christianshewitt@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: amlogic: add more basic audio support | expand |
On Tue 15 Aug 2023 at 09:27, Christian Hewitt <christianshewitt@gmail.com> wrote: > This mini-series adds basic audio support to the P200/P201 (GXBB) and U200 (G12A) > reference boards. Few people likely have the original reference boards which have > extra audio capabilities, but the device-trees are widely [ab]used by users with > Android set-top boxes whose hardware is copy/pasted from the reference designs to > get working installs. Adding basic audio support does no harm to the real boards > and helps the secondary cause. Still, this is something you have not tested on the u200 reference design. I believe this was already discussed in the past. The u200 is far more complex when it comes to audio and certainly would not work on this no-name android device. These device are heavily "inspired" by the reference, but trimmed down in many aspect including audio capabilities - NOT copied. People abusing the u200 or p200 DT does make the patchset valid > > Christian Hewitt (3): > arm64: dts: meson: add audio playback to p200 > arm64: dts: meson: add audio playback to p201 > arm64: dts: meson: add audio playback to u200 > > .../boot/dts/amlogic/meson-g12a-u200.dts | 129 ++++++++++++++++++ > .../boot/dts/amlogic/meson-gxbb-p200.dts | 60 ++++++++ > .../boot/dts/amlogic/meson-gxbb-p201.dts | 39 ++++++ > 3 files changed, 228 insertions(+)
Hi, On 15/08/2023 11:37, Jerome Brunet wrote: > > On Tue 15 Aug 2023 at 09:27, Christian Hewitt <christianshewitt@gmail.com> wrote: > >> This mini-series adds basic audio support to the P200/P201 (GXBB) and U200 (G12A) >> reference boards. Few people likely have the original reference boards which have >> extra audio capabilities, but the device-trees are widely [ab]used by users with >> Android set-top boxes whose hardware is copy/pasted from the reference designs to >> get working installs. Adding basic audio support does no harm to the real boards >> and helps the secondary cause. > > Still, this is something you have not tested on the u200 reference > design. I believe this was already discussed in the past. > > The u200 is far more complex when it comes to audio and certainly would > not work on this no-name android device. These device are heavily > "inspired" by the reference, but trimmed down in many aspect including > audio capabilities - NOT copied. I understand you point, but those changes only adds "internal" audio & basic spdif capabilities so it won't affect the on-board audio electronics in any way. > > People abusing the u200 or p200 DT does make the patchset valid This is a reality, but still I think this patchset is valid and I'll pick those since they are used for years out-of-tree and probably works very fine in the reference design boards. Neil > >> >> Christian Hewitt (3): >> arm64: dts: meson: add audio playback to p200 >> arm64: dts: meson: add audio playback to p201 >> arm64: dts: meson: add audio playback to u200 >> >> .../boot/dts/amlogic/meson-g12a-u200.dts | 129 ++++++++++++++++++ >> .../boot/dts/amlogic/meson-gxbb-p200.dts | 60 ++++++++ >> .../boot/dts/amlogic/meson-gxbb-p201.dts | 39 ++++++ >> 3 files changed, 228 insertions(+) >
Hi, On Tue, 15 Aug 2023 09:27:48 +0000, Christian Hewitt wrote: > This mini-series adds basic audio support to the P200/P201 (GXBB) and U200 (G12A) > reference boards. Few people likely have the original reference boards which have > extra audio capabilities, but the device-trees are widely [ab]used by users with > Android set-top boxes whose hardware is copy/pasted from the reference designs to > get working installs. Adding basic audio support does no harm to the real boards > and helps the secondary cause. > > [...] Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.7/arm64-dt) [1/3] arm64: dts: meson: add audio playback to p200 https://git.kernel.org/amlogic/c/61373cc074128c40d53857803371c4a9384d4200 [2/3] arm64: dts: meson: add audio playback to p201 https://git.kernel.org/amlogic/c/2b2827a19024abcf879c18053ae3f2fc23891ad4 [3/3] arm64: dts: meson: add audio playback to u200 https://git.kernel.org/amlogic/c/cfae4eadb7cd44cb5f17285e18477bed4ae5f03c These changes has been applied on the intermediate git tree [1]. The v6.7/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers for inclusion in their intermediate git branches in order to be sent to Linus during the next merge window, or sooner if it's a set of fixes. In the cases of fixes, those will be merged in the current release candidate kernel and as soon they appear on the Linux master branch they will be backported to the previous Stable and Long-Stable kernels [2]. The intermediate git branches are merged daily in the linux-next tree [3], people are encouraged testing these pre-release kernels and report issues on the relevant mailing-lists. If problems are discovered on those changes, please submit a signed-off-by revert patch followed by a corrective changeset. [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git