| Message ID | 20230822131237.1022815-1-lizetao1@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | spi: Use devm_clk_get_*() helper function to simplify the drivers. | expand |
On Tue, 22 Aug 2023 21:12:12 +0800 Li Zetao <lizetao1@huawei.com> wrote: > Commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared > and enabled clocks") provides a new helper function for prepared and > enabled clocks when a driver keeps a clock prepared (or enabled) during > the whole lifetime of the driver. So where drivers get clocks and enable > them immediately, it can be combined into a single function > devm_clk_get_*(). Moreover, the unprepare and disable function > has been registered to devm_clk_state, and before devm_clk_state is > released, the clocks will be unprepareed and disable, so it is unnecessary > to unprepare and disable clocks explicitly when remove drivers or in the > error handling path. For all except 2, 12 and 24 they look good to me and I don't think there are any other ordering issues of the sort we tend to see in devm conversions where things get turned off later than in pre devm version. So for those.. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Li Zetao (25): > spi: ar934x: Use helper function devm_clk_get_enabled() > spi: armada-3700: Use helper function devm_clk_get_prepared() > spi: aspeed: Use helper function devm_clk_get_enabled() > spi: ath79: Use helper function devm_clk_get_enabled() > spi: spi-axi-spi-engine: Use helper function devm_clk_get_enabled() > spi: bcm2835: Use helper function devm_clk_get_enabled() > spi: bcm2835aux: Use helper function devm_clk_get_enabled() > spi: spi-cadence: Use helper function devm_clk_get_enabled() > spi: spi-cavium-thunderx: Use helper function devm_clk_get_enabled() > spi: davinci: Use helper function devm_clk_get_enabled() > spi: dw-bt1: Use helper function devm_clk_get_enabled() > spi: dw-mmio: Use helper function devm_clk_get_*() > spi: spi-fsl-dspi: Use helper function devm_clk_get_enabled() > spi: lantiq-ssc: Use helper function devm_clk_get_enabled() > spi: meson-spicc: Use helper function devm_clk_get_enabled() > spi: spi-meson-spifc: Use helper function devm_clk_get_enabled() > spi: microchip-core-qspi: Use helper function devm_clk_get_enabled() > spi: microchip-core: Use helper function devm_clk_get_enabled() > spi: mtk-snfi: Use helper function devm_clk_get_enabled() > spi: npcm-fiu: Use helper function devm_clk_get_enabled() > spi: orion: Use helper function devm_clk_get_enabled() > spi: pic32-sqi: Use helper function devm_clk_get_enabled() > spi: pic32: Use helper function devm_clk_get_enabled() > spi: spl022: Use helper function devm_clk_get_enabled() > spi: rockchip: Use helper function devm_clk_get_enabled() > > drivers/spi/spi-ar934x.c | 22 ++-------- > drivers/spi/spi-armada-3700.c | 18 ++------ > drivers/spi/spi-aspeed-smc.c | 16 +------ > drivers/spi/spi-ath79.c | 11 +---- > drivers/spi/spi-axi-spi-engine.c | 25 +++-------- > drivers/spi/spi-bcm2835.c | 11 +---- > drivers/spi/spi-bcm2835aux.c | 23 ++-------- > drivers/spi/spi-cadence.c | 23 ++-------- > drivers/spi/spi-cavium-thunderx.c | 8 +--- > drivers/spi/spi-davinci.c | 11 +---- > drivers/spi/spi-dw-bt1.c | 23 +++------- > drivers/spi/spi-dw-mmio.c | 20 +++------ > drivers/spi/spi-fsl-dspi.c | 12 ++---- > drivers/spi/spi-lantiq-ssc.c | 10 +---- > drivers/spi/spi-meson-spicc.c | 33 +++------------ > drivers/spi/spi-meson-spifc.c | 17 ++------ > drivers/spi/spi-microchip-core-qspi.c | 29 +++---------- > drivers/spi/spi-microchip-core.c | 9 +--- > drivers/spi/spi-mtk-snfi.c | 61 ++++----------------------- > drivers/spi/spi-npcm-fiu.c | 14 ++---- > drivers/spi/spi-orion.c | 11 +---- > drivers/spi/spi-pic32-sqi.c | 27 ++---------- > drivers/spi/spi-pic32.c | 8 +--- > drivers/spi/spi-pl022.c | 21 +++------ > drivers/spi/spi-rockchip.c | 30 +++---------- > 25 files changed, 88 insertions(+), 405 deletions(-) >
Commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared
and enabled clocks") provides a new helper function for prepared and
enabled clocks when a driver keeps a clock prepared (or enabled) during
the whole lifetime of the driver. So where drivers get clocks and enable
them immediately, it can be combined into a single function
devm_clk_get_*(). Moreover, the unprepare and disable function
has been registered to devm_clk_state, and before devm_clk_state is
released, the clocks will be unprepareed and disable, so it is unnecessary
to unprepare and disable clocks explicitly when remove drivers or in the
error handling path.
Change log:
v2:
- Remove empty function a3700_spi_remove(), while is nothing to do.
- Return directly instead of calling reset_control_deassert(), because
the reset control handler hasn't been requested yet in
dw_spi_mmio_probe(). And use the "out_reset" label instead of "out"
before calling pm_runtime_enable().
- Delete the modification of odd formatting, it should probably be a
separate patch.
v1: https://lore.kernel.org/all/20230822131237.1022815-1-lizetao1@huawei.com/
Li Zetao (25):
spi: ar934x: Use helper function devm_clk_get_enabled()
spi: armada-3700: Use helper function devm_clk_get_prepared()
spi: aspeed: Use helper function devm_clk_get_enabled()
spi: ath79: Use helper function devm_clk_get_enabled()
spi: spi-axi-spi-engine: Use helper function devm_clk_get_enabled()
spi: bcm2835: Use helper function devm_clk_get_enabled()
spi: bcm2835aux: Use helper function devm_clk_get_enabled()
spi: spi-cadence: Use helper function devm_clk_get_enabled()
spi: spi-cavium-thunderx: Use helper function devm_clk_get_enabled()
spi: davinci: Use helper function devm_clk_get_enabled()
spi: dw-bt1: Use helper function devm_clk_get_enabled()
spi: dw-mmio: Use helper function devm_clk_get_*()
spi: spi-fsl-dspi: Use helper function devm_clk_get_enabled()
spi: lantiq-ssc: Use helper function devm_clk_get_enabled()
spi: meson-spicc: Use helper function devm_clk_get_enabled()
spi: spi-meson-spifc: Use helper function devm_clk_get_enabled()
spi: microchip-core-qspi: Use helper function devm_clk_get_enabled()
spi: microchip-core: Use helper function devm_clk_get_enabled()
spi: mtk-snfi: Use helper function devm_clk_get_enabled()
spi: npcm-fiu: Use helper function devm_clk_get_enabled()
spi: orion: Use helper function devm_clk_get_enabled()
spi: pic32-sqi: Use helper function devm_clk_get_enabled()
spi: pic32: Use helper function devm_clk_get_enabled()
spi: spl022: Use helper function devm_clk_get_enabled()
spi: rockchip: Use helper function devm_clk_get_enabled()
drivers/spi/spi-ar934x.c | 22 ++--------
drivers/spi/spi-armada-3700.c | 23 ++--------
drivers/spi/spi-aspeed-smc.c | 16 +------
drivers/spi/spi-ath79.c | 11 +----
drivers/spi/spi-axi-spi-engine.c | 25 +++--------
drivers/spi/spi-bcm2835.c | 11 +----
drivers/spi/spi-bcm2835aux.c | 23 ++--------
drivers/spi/spi-cadence.c | 23 ++--------
drivers/spi/spi-cavium-thunderx.c | 8 +---
drivers/spi/spi-davinci.c | 11 +----
drivers/spi/spi-dw-bt1.c | 23 +++-------
drivers/spi/spi-dw-mmio.c | 31 ++++----------
drivers/spi/spi-fsl-dspi.c | 12 ++----
drivers/spi/spi-lantiq-ssc.c | 10 +----
drivers/spi/spi-meson-spicc.c | 33 +++------------
drivers/spi/spi-meson-spifc.c | 17 ++------
drivers/spi/spi-microchip-core-qspi.c | 29 +++----------
drivers/spi/spi-microchip-core.c | 9 +---
drivers/spi/spi-mtk-snfi.c | 61 ++++-----------------------
drivers/spi/spi-npcm-fiu.c | 14 ++----
drivers/spi/spi-orion.c | 11 +----
drivers/spi/spi-pic32-sqi.c | 27 ++----------
drivers/spi/spi-pic32.c | 8 +---
drivers/spi/spi-pl022.c | 11 +----
drivers/spi/spi-rockchip.c | 30 +++----------
25 files changed, 87 insertions(+), 412 deletions(-)
On Wed, Aug 23, 2023 at 09:39:13PM +0800, Li Zetao wrote: > Commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared > and enabled clocks") provides a new helper function for prepared and > enabled clocks when a driver keeps a clock prepared (or enabled) during > the whole lifetime of the driver. So where drivers get clocks and enable > them immediately, it can be combined into a single function Please don't send new patches in reply to old patches or serieses, this makes it harder for both people and tools to understand what is going on - it can bury things in mailboxes and make it difficult to keep track of what current patches are, both for the new patches and the old ones.
On Wed, 23 Aug 2023 21:39:13 +0800, Li Zetao wrote: > Commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared > and enabled clocks") provides a new helper function for prepared and > enabled clocks when a driver keeps a clock prepared (or enabled) during > the whole lifetime of the driver. So where drivers get clocks and enable > them immediately, it can be combined into a single function > devm_clk_get_*(). Moreover, the unprepare and disable function > has been registered to devm_clk_state, and before devm_clk_state is > released, the clocks will be unprepareed and disable, so it is unnecessary > to unprepare and disable clocks explicitly when remove drivers or in the > error handling path. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [01/25] spi: ar934x: Use helper function devm_clk_get_enabled() commit: 1d3ea34b7b69b2cbdcc82f1d399705c06ea5f748 [02/25] spi: armada-3700: Use helper function devm_clk_get_prepared() commit: f918b3a67ccbcf326a80100c17e107eece5df868 [03/25] spi: aspeed: Use helper function devm_clk_get_enabled() commit: 9ee8fbc05ef0b69e8cb4295b2663e044dd3868a3 [04/25] spi: ath79: Use helper function devm_clk_get_enabled() commit: b3422ea3913e27fd43a7a1883f358cb20599289e [05/25] spi: spi-axi-spi-engine: Use helper function devm_clk_get_enabled() commit: a08199b309f833fd4221ab5ee2391c791fe26385 [06/25] spi: bcm2835: Use helper function devm_clk_get_enabled() commit: ba85f5fad849821bfce0ee154a72df7e2376c5eb [07/25] spi: bcm2835aux: Use helper function devm_clk_get_enabled() commit: 0135a38436111366bc2fe6d3cd82a9c2cc92ce7f [08/25] spi: spi-cadence: Use helper function devm_clk_get_enabled() commit: f64b1600f92e786e502cc30d31d9e3c5f2f6d682 [09/25] spi: spi-cavium-thunderx: Use helper function devm_clk_get_enabled() commit: c32cb76e8d5e487698f8eceb5b53df95a33fe388 [10/25] spi: davinci: Use helper function devm_clk_get_enabled() commit: 9dc2aa96a3533215fbed9cf1297f7aa70dae840b [11/25] spi: dw-bt1: Use helper function devm_clk_get_enabled() commit: 10c3937890be2c53bfa4aaf3b22a46749857f86a [12/25] spi: dw-mmio: Use helper function devm_clk_get_*() commit: 349112b6769ec0018404f87dd4632f8ea393fcaf [13/25] spi: spi-fsl-dspi: Use helper function devm_clk_get_enabled() commit: 4812bc31af2b523d4da8386a524a2cd2f6f5919b [14/25] spi: lantiq-ssc: Use helper function devm_clk_get_enabled() commit: e2b9622b2a3d058e7d06827b99487b27f777b9c2 [15/25] spi: meson-spicc: Use helper function devm_clk_get_enabled() commit: 7ef51102d32ddc4776b2cdd583fe84afb84c823f [16/25] spi: spi-meson-spifc: Use helper function devm_clk_get_enabled() commit: c45fd1217b38048332c4f5bff8bfb7c1fe6ab6dd [17/25] spi: microchip-core-qspi: Use helper function devm_clk_get_enabled() commit: e922f3fff21445117e9196bd8e940ad8e15ca8c7 [18/25] spi: microchip-core: Use helper function devm_clk_get_enabled() commit: 605204fcb9c49818a8a7e533147061a305ac39e3 [19/25] spi: mtk-snfi: Use helper function devm_clk_get_enabled() commit: a06b6935f10267a300be724dca11226d6d519156 [20/25] spi: npcm-fiu: Use helper function devm_clk_get_enabled() commit: 82c4fadb0b957c817b5a3fcc05dc774bf32a4d07 [21/25] spi: orion: Use helper function devm_clk_get_enabled() commit: bbd0a66b85fe860e8b6acfb1739d15b517a4f6fb [22/25] spi: pic32-sqi: Use helper function devm_clk_get_enabled() commit: 909d4cd6bc316e6cd7958832f3efe9e2fd51dcbf [23/25] spi: pic32: Use helper function devm_clk_get_enabled() commit: 6b6cc88c4e5b42d2ba6af43152af6d9d96872ee8 [24/25] spi: spl022: Use helper function devm_clk_get_enabled() commit: 9351339c1a99cca47e6fbeef88b1ef6438d36127 [25/25] spi: rockchip: Use helper function devm_clk_get_enabled() commit: d6c612a34740118855cd1c8acc4339adea686266 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared and enabled clocks") provides a new helper function for prepared and enabled clocks when a driver keeps a clock prepared (or enabled) during the whole lifetime of the driver. So where drivers get clocks and enable them immediately, it can be combined into a single function devm_clk_get_*(). Moreover, the unprepare and disable function has been registered to devm_clk_state, and before devm_clk_state is released, the clocks will be unprepareed and disable, so it is unnecessary to unprepare and disable clocks explicitly when remove drivers or in the error handling path. Li Zetao (25): spi: ar934x: Use helper function devm_clk_get_enabled() spi: armada-3700: Use helper function devm_clk_get_prepared() spi: aspeed: Use helper function devm_clk_get_enabled() spi: ath79: Use helper function devm_clk_get_enabled() spi: spi-axi-spi-engine: Use helper function devm_clk_get_enabled() spi: bcm2835: Use helper function devm_clk_get_enabled() spi: bcm2835aux: Use helper function devm_clk_get_enabled() spi: spi-cadence: Use helper function devm_clk_get_enabled() spi: spi-cavium-thunderx: Use helper function devm_clk_get_enabled() spi: davinci: Use helper function devm_clk_get_enabled() spi: dw-bt1: Use helper function devm_clk_get_enabled() spi: dw-mmio: Use helper function devm_clk_get_*() spi: spi-fsl-dspi: Use helper function devm_clk_get_enabled() spi: lantiq-ssc: Use helper function devm_clk_get_enabled() spi: meson-spicc: Use helper function devm_clk_get_enabled() spi: spi-meson-spifc: Use helper function devm_clk_get_enabled() spi: microchip-core-qspi: Use helper function devm_clk_get_enabled() spi: microchip-core: Use helper function devm_clk_get_enabled() spi: mtk-snfi: Use helper function devm_clk_get_enabled() spi: npcm-fiu: Use helper function devm_clk_get_enabled() spi: orion: Use helper function devm_clk_get_enabled() spi: pic32-sqi: Use helper function devm_clk_get_enabled() spi: pic32: Use helper function devm_clk_get_enabled() spi: spl022: Use helper function devm_clk_get_enabled() spi: rockchip: Use helper function devm_clk_get_enabled() drivers/spi/spi-ar934x.c | 22 ++-------- drivers/spi/spi-armada-3700.c | 18 ++------ drivers/spi/spi-aspeed-smc.c | 16 +------ drivers/spi/spi-ath79.c | 11 +---- drivers/spi/spi-axi-spi-engine.c | 25 +++-------- drivers/spi/spi-bcm2835.c | 11 +---- drivers/spi/spi-bcm2835aux.c | 23 ++-------- drivers/spi/spi-cadence.c | 23 ++-------- drivers/spi/spi-cavium-thunderx.c | 8 +--- drivers/spi/spi-davinci.c | 11 +---- drivers/spi/spi-dw-bt1.c | 23 +++------- drivers/spi/spi-dw-mmio.c | 20 +++------ drivers/spi/spi-fsl-dspi.c | 12 ++---- drivers/spi/spi-lantiq-ssc.c | 10 +---- drivers/spi/spi-meson-spicc.c | 33 +++------------ drivers/spi/spi-meson-spifc.c | 17 ++------ drivers/spi/spi-microchip-core-qspi.c | 29 +++---------- drivers/spi/spi-microchip-core.c | 9 +--- drivers/spi/spi-mtk-snfi.c | 61 ++++----------------------- drivers/spi/spi-npcm-fiu.c | 14 ++---- drivers/spi/spi-orion.c | 11 +---- drivers/spi/spi-pic32-sqi.c | 27 ++---------- drivers/spi/spi-pic32.c | 8 +--- drivers/spi/spi-pl022.c | 21 +++------ drivers/spi/spi-rockchip.c | 30 +++---------- 25 files changed, 88 insertions(+), 405 deletions(-)