| Message ID | 20230916075829.1560-1-jszhang@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | convert to devm_stmmac_probe_config_dt | expand |
Jisheng Zhang wrote: > Russell pointed out there's a new devm_stmmac_probe_config_dt() > helper now when reviewing my starfive gmac error handling patch[1]. > After greping the code, this nice helper was introduced by Bartosz in > [2], I think it's time to convert all dwmac users to this helper and > finally complete the TODO in [2] "but once all users of the old > stmmac_pltfr_remove() are converted to the devres helper, it will be > renamed back to stmmac_pltfr_remove() and the no_dt function removed." Thanks for doing this. Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com> > > Link: https://lore.kernel.org/netdev/ZOtWmedBsa6wQQ6+@shell.armlinux.org.uk/ [1] > Link: https://lore.kernel.org/all/20230623100417.93592-1-brgl@bgdev.pl/ [2] > > Since v1: > - rebase on new net-next > - add make stmmac_{probe|remove}_config_dt static as suggested by Russell. > > Jisheng Zhang (23): > net: stmmac: dwmac-anarion: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-dwc-qos-eth: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-generic: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-generic: use devm_stmmac_pltfr_probe() > net: stmmac: dwmac-imx: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-ingenic: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-intel-plat: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-ipq806x: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-lpc18xx: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-mediatek: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-meson: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-meson8b: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-rk: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-socfpga: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-starfive: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-sti: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-stm32: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-sun8i: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-sunxi: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-tegra: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-visconti: use devm_stmmac_probe_config_dt() > net: stmmac: rename stmmac_pltfr_remove_no_dt to stmmac_pltfr_remove > net: stmmac: make stmmac_{probe|remove}_config_dt static > > .../ethernet/stmicro/stmmac/dwmac-anarion.c | 10 +-- > .../stmicro/stmmac/dwmac-dwc-qos-eth.c | 15 +--- > .../ethernet/stmicro/stmmac/dwmac-generic.c | 15 +--- > .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 13 ++-- > .../ethernet/stmicro/stmmac/dwmac-ingenic.c | 33 +++------ > .../stmicro/stmmac/dwmac-intel-plat.c | 25 +++---- > .../ethernet/stmicro/stmmac/dwmac-ipq806x.c | 27 +++---- > .../ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 19 ++--- > .../ethernet/stmicro/stmmac/dwmac-mediatek.c | 6 +- > .../net/ethernet/stmicro/stmmac/dwmac-meson.c | 25 ++----- > .../ethernet/stmicro/stmmac/dwmac-meson8b.c | 53 +++++--------- > .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 14 ++-- > .../ethernet/stmicro/stmmac/dwmac-socfpga.c | 16 ++--- > .../ethernet/stmicro/stmmac/dwmac-starfive.c | 10 +-- > .../net/ethernet/stmicro/stmmac/dwmac-sti.c | 14 ++-- > .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 17 ++--- > .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 +- > .../net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 23 +++--- > .../net/ethernet/stmicro/stmmac/dwmac-tegra.c | 10 ++- > .../ethernet/stmicro/stmmac/dwmac-visconti.c | 18 ++--- > .../ethernet/stmicro/stmmac/stmmac_platform.c | 70 ++++++------------- > .../ethernet/stmicro/stmmac/stmmac_platform.h | 5 -- > 22 files changed, 127 insertions(+), 317 deletions(-) > > -- > 2.40.1
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Sat, 16 Sep 2023 15:58:06 +0800 you wrote: > Russell pointed out there's a new devm_stmmac_probe_config_dt() > helper now when reviewing my starfive gmac error handling patch[1]. > After greping the code, this nice helper was introduced by Bartosz in > [2], I think it's time to convert all dwmac users to this helper and > finally complete the TODO in [2] "but once all users of the old > stmmac_pltfr_remove() are converted to the devres helper, it will be > renamed back to stmmac_pltfr_remove() and the no_dt function removed." > > [...] Here is the summary with links: - [net-next,v2,01/23] net: stmmac: dwmac-anarion: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/6f799fd9dda7 - [net-next,v2,02/23] net: stmmac: dwmac-dwc-qos-eth: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/0485825dd6a8 - [net-next,v2,03/23] net: stmmac: dwmac-generic: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/d53b19d2a1a8 - [net-next,v2,04/23] net: stmmac: dwmac-generic: use devm_stmmac_pltfr_probe() https://git.kernel.org/netdev/net-next/c/14ec0fc582c5 - [net-next,v2,05/23] net: stmmac: dwmac-imx: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/115c9248b19b - [net-next,v2,06/23] net: stmmac: dwmac-ingenic: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/6bb53b2abf30 - [net-next,v2,07/23] net: stmmac: dwmac-intel-plat: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/abea8fd5e801 - [net-next,v2,08/23] net: stmmac: dwmac-ipq806x: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/72ab86c27d4e - [net-next,v2,09/23] net: stmmac: dwmac-lpc18xx: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/d30c08a3b001 - [net-next,v2,10/23] net: stmmac: dwmac-mediatek: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/d7209c056a49 - [net-next,v2,11/23] net: stmmac: dwmac-meson: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/780b63ae208e - [net-next,v2,12/23] net: stmmac: dwmac-meson8b: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/551022d680ec - [net-next,v2,13/23] net: stmmac: dwmac-rk: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/8eee20e10d6f - [net-next,v2,14/23] net: stmmac: dwmac-socfpga: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/9086d3f2b560 - [net-next,v2,15/23] net: stmmac: dwmac-starfive: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/6d6c11937359 - [net-next,v2,16/23] net: stmmac: dwmac-sti: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/c9445e0bd729 - [net-next,v2,17/23] net: stmmac: dwmac-stm32: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/373845154618 - [net-next,v2,18/23] net: stmmac: dwmac-sun8i: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/9bdf6909877c - [net-next,v2,19/23] net: stmmac: dwmac-sunxi: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/291595337626 - [net-next,v2,20/23] net: stmmac: dwmac-tegra: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/acf73ccff08e - [net-next,v2,21/23] net: stmmac: dwmac-visconti: use devm_stmmac_probe_config_dt() https://git.kernel.org/netdev/net-next/c/d336a117b593 - [net-next,v2,22/23] net: stmmac: rename stmmac_pltfr_remove_no_dt to stmmac_pltfr_remove https://git.kernel.org/netdev/net-next/c/2c9fc838067b - [net-next,v2,23/23] net: stmmac: make stmmac_{probe|remove}_config_dt static https://git.kernel.org/netdev/net-next/c/b2504f649bda You are awesome, thank you!
On Sat, Sep 16, 2023 at 03:58:06PM +0800, Jisheng Zhang wrote: > Russell pointed out there's a new devm_stmmac_probe_config_dt() > helper now when reviewing my starfive gmac error handling patch[1]. > After greping the code, this nice helper was introduced by Bartosz in > [2], I think it's time to convert all dwmac users to this helper and > finally complete the TODO in [2] "but once all users of the old > stmmac_pltfr_remove() are converted to the devres helper, it will be > renamed back to stmmac_pltfr_remove() and the no_dt function removed." > > Link: https://lore.kernel.org/netdev/ZOtWmedBsa6wQQ6+@shell.armlinux.org.uk/ [1] > Link: https://lore.kernel.org/all/20230623100417.93592-1-brgl@bgdev.pl/ [2] I see the series is already merged in. In anyway here is my tag: Reviewed-by: Serge Semin <fancer.lancer@gmail.com> Thanks for submitting the set. -Serge(y) > > Since v1: > - rebase on new net-next > - add make stmmac_{probe|remove}_config_dt static as suggested by Russell. > > Jisheng Zhang (23): > net: stmmac: dwmac-anarion: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-dwc-qos-eth: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-generic: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-generic: use devm_stmmac_pltfr_probe() > net: stmmac: dwmac-imx: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-ingenic: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-intel-plat: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-ipq806x: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-lpc18xx: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-mediatek: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-meson: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-meson8b: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-rk: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-socfpga: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-starfive: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-sti: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-stm32: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-sun8i: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-sunxi: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-tegra: use devm_stmmac_probe_config_dt() > net: stmmac: dwmac-visconti: use devm_stmmac_probe_config_dt() > net: stmmac: rename stmmac_pltfr_remove_no_dt to stmmac_pltfr_remove > net: stmmac: make stmmac_{probe|remove}_config_dt static > > .../ethernet/stmicro/stmmac/dwmac-anarion.c | 10 +-- > .../stmicro/stmmac/dwmac-dwc-qos-eth.c | 15 +--- > .../ethernet/stmicro/stmmac/dwmac-generic.c | 15 +--- > .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 13 ++-- > .../ethernet/stmicro/stmmac/dwmac-ingenic.c | 33 +++------ > .../stmicro/stmmac/dwmac-intel-plat.c | 25 +++---- > .../ethernet/stmicro/stmmac/dwmac-ipq806x.c | 27 +++---- > .../ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 19 ++--- > .../ethernet/stmicro/stmmac/dwmac-mediatek.c | 6 +- > .../net/ethernet/stmicro/stmmac/dwmac-meson.c | 25 ++----- > .../ethernet/stmicro/stmmac/dwmac-meson8b.c | 53 +++++--------- > .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 14 ++-- > .../ethernet/stmicro/stmmac/dwmac-socfpga.c | 16 ++--- > .../ethernet/stmicro/stmmac/dwmac-starfive.c | 10 +-- > .../net/ethernet/stmicro/stmmac/dwmac-sti.c | 14 ++-- > .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 17 ++--- > .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 +- > .../net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 23 +++--- > .../net/ethernet/stmicro/stmmac/dwmac-tegra.c | 10 ++- > .../ethernet/stmicro/stmmac/dwmac-visconti.c | 18 ++--- > .../ethernet/stmicro/stmmac/stmmac_platform.c | 70 ++++++------------- > .../ethernet/stmicro/stmmac/stmmac_platform.h | 5 -- > 22 files changed, 127 insertions(+), 317 deletions(-) > > -- > 2.40.1 > >
Russell pointed out there's a new devm_stmmac_probe_config_dt() helper now when reviewing my starfive gmac error handling patch[1]. After greping the code, this nice helper was introduced by Bartosz in [2], I think it's time to convert all dwmac users to this helper and finally complete the TODO in [2] "but once all users of the old stmmac_pltfr_remove() are converted to the devres helper, it will be renamed back to stmmac_pltfr_remove() and the no_dt function removed." Link: https://lore.kernel.org/netdev/ZOtWmedBsa6wQQ6+@shell.armlinux.org.uk/ [1] Link: https://lore.kernel.org/all/20230623100417.93592-1-brgl@bgdev.pl/ [2] Since v1: - rebase on new net-next - add make stmmac_{probe|remove}_config_dt static as suggested by Russell. Jisheng Zhang (23): net: stmmac: dwmac-anarion: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-dwc-qos-eth: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-generic: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-generic: use devm_stmmac_pltfr_probe() net: stmmac: dwmac-imx: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-ingenic: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-intel-plat: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-ipq806x: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-lpc18xx: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-mediatek: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-meson: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-meson8b: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-rk: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-socfpga: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-starfive: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-sti: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-stm32: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-sun8i: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-sunxi: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-tegra: use devm_stmmac_probe_config_dt() net: stmmac: dwmac-visconti: use devm_stmmac_probe_config_dt() net: stmmac: rename stmmac_pltfr_remove_no_dt to stmmac_pltfr_remove net: stmmac: make stmmac_{probe|remove}_config_dt static .../ethernet/stmicro/stmmac/dwmac-anarion.c | 10 +-- .../stmicro/stmmac/dwmac-dwc-qos-eth.c | 15 +--- .../ethernet/stmicro/stmmac/dwmac-generic.c | 15 +--- .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 13 ++-- .../ethernet/stmicro/stmmac/dwmac-ingenic.c | 33 +++------ .../stmicro/stmmac/dwmac-intel-plat.c | 25 +++---- .../ethernet/stmicro/stmmac/dwmac-ipq806x.c | 27 +++---- .../ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 19 ++--- .../ethernet/stmicro/stmmac/dwmac-mediatek.c | 6 +- .../net/ethernet/stmicro/stmmac/dwmac-meson.c | 25 ++----- .../ethernet/stmicro/stmmac/dwmac-meson8b.c | 53 +++++--------- .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 14 ++-- .../ethernet/stmicro/stmmac/dwmac-socfpga.c | 16 ++--- .../ethernet/stmicro/stmmac/dwmac-starfive.c | 10 +-- .../net/ethernet/stmicro/stmmac/dwmac-sti.c | 14 ++-- .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 17 ++--- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 +- .../net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 23 +++--- .../net/ethernet/stmicro/stmmac/dwmac-tegra.c | 10 ++- .../ethernet/stmicro/stmmac/dwmac-visconti.c | 18 ++--- .../ethernet/stmicro/stmmac/stmmac_platform.c | 70 ++++++------------- .../ethernet/stmicro/stmmac/stmmac_platform.h | 5 -- 22 files changed, 127 insertions(+), 317 deletions(-)