| Message ID | 20240314070433.4151931-1-adeep@lexina.in (mailing list archive) |
|---|---|
| Headers | show |
| Series | soc: amlogic: add new meson-gx-socinfo-sm driver | expand |
On Thu, Mar 14, 2024 at 09:59:50AM +0300, Viacheslav Bocharov wrote: > The Amlogic Meson SoC Secure Monitor implements a call to retrieve an > unique SoC ID starting from the GX Family and all new families. > But GX-family chips (e.g. GXB, GXL and newer) supports also 128-bit > chip ID. 128-bit chip ID consists 32-bit SoC version and 96-bit OTP data. > How old or new are these SoCs ? The reason I ask is that it is really sad to see vendors still creating their custom interfaces for such things despite the standard SMCCC interface SOC_ID introduced in SMCCC v1.2 some time in 2020. Hopefully they migrated to the std interface and just use the driver in the kernel without needing to add this every time they fancy playing with the interface for no reason.
Hi! 14/03/2024 13.40, Sudeep Holla wrote: > On Thu, Mar 14, 2024 at 09:59:50AM +0300, Viacheslav Bocharov wrote: >> The Amlogic Meson SoC Secure Monitor implements a call to retrieve an >> unique SoC ID starting from the GX Family and all new families. >> But GX-family chips (e.g. GXB, GXL and newer) supports also 128-bit >> chip ID. 128-bit chip ID consists 32-bit SoC version and 96-bit OTP data. >> > > How old or new are these SoCs ? The reason I ask is that it is really > sad to see vendors still creating their custom interfaces for such things > despite the standard SMCCC interface SOC_ID introduced in SMCCC v1.2 some > time in 2020. Most of these SoC were created before 2020. > > Hopefully they migrated to the std interface and just use the driver in > the kernel without needing to add this every time they fancy playing > with the interface for no reason. >
On Thu, Mar 14, 2024 at 03:25:02PM +0300, Viacheslav wrote: > Hi! > > 14/03/2024 13.40, Sudeep Holla wrote: > > On Thu, Mar 14, 2024 at 09:59:50AM +0300, Viacheslav Bocharov wrote: > > > The Amlogic Meson SoC Secure Monitor implements a call to retrieve an > > > unique SoC ID starting from the GX Family and all new families. > > > But GX-family chips (e.g. GXB, GXL and newer) supports also 128-bit > > > chip ID. 128-bit chip ID consists 32-bit SoC version and 96-bit OTP data. > > > > > > > How old or new are these SoCs ? The reason I ask is that it is really > > sad to see vendors still creating their custom interfaces for such things > > despite the standard SMCCC interface SOC_ID introduced in SMCCC v1.2 some > > time in 2020. > > Most of these SoC were created before 2020. > Fair enough then. Hope they use SOC_ID on newer SoCs.
The Amlogic Meson SoC Secure Monitor implements a call to retrieve an unique SoC ID starting from the GX Family and all new families. But GX-family chips (e.g. GXB, GXL and newer) supports also 128-bit chip ID. 128-bit chip ID consists 32-bit SoC version and 96-bit OTP data. This is next attempt to publish data from the Amlogic secure monitor chipid call. After discussions with Neil Armstrong, it was decided to publish the chipid call results through the soc driver. Since soc_device_match cannot wait for the soc driver to load, and the secure monitor calls in turn depend on the sm driver, it was necessary to create a new driver rather than expand an existing one. In the patches, in addition to writing the driver: - convert commonly used structures and functions of the meson-gx-socinfo driver to a header file. - add secure-monitor references for amlogic,meson-gx-ao-secure sections in dts files of the a1, axg, g12, gx families. --- Changes v2 [1] -> v3: - rebase - update dependency in Kconfig for MESON_GX_SOCINFO_SM - add links to secure-monitor in soc driver sections for A1, AXG, GX, G12 v1 [2] -> v2: - create cpu_id structure for socinfo variable - create meson_sm_chip_id for result of sm call - remove shared functions - move from funcs for bit operations to C bit fields Links: - [1] https://lore.kernel.org/linux-arm-kernel/20240221143654.544444-1-adeep@lexina.in/ - [2] https://lore.kernel.org/linux-arm-kernel/202311242104.RjBPI3uI-lkp@intel.com/T/ Viacheslav Bocharov (4): soc: amlogic: meson-gx-socinfo: move common code to header file soc: amlogic: meson-gx-socinfo-sm: Add Amlogic secure-monitor SoC Information driver soc: amlogic: meson-gx-socinfo: add new definition for Amlogic A113X package arm64: dts: meson: add dts links to secure-monitor for soc driver in a1, axg, gx, g12 arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 1 + arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 1 + .../boot/dts/amlogic/meson-g12-common.dtsi | 1 + arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 + drivers/soc/amlogic/Kconfig | 10 + drivers/soc/amlogic/Makefile | 1 + .../soc/amlogic/meson-gx-socinfo-internal.h | 121 +++++++++++ drivers/soc/amlogic/meson-gx-socinfo-sm.c | 192 ++++++++++++++++++ drivers/soc/amlogic/meson-gx-socinfo.c | 136 ++----------- 9 files changed, 342 insertions(+), 122 deletions(-) create mode 100644 drivers/soc/amlogic/meson-gx-socinfo-internal.h create mode 100644 drivers/soc/amlogic/meson-gx-socinfo-sm.c base-commit: 480e035fc4c714fb5536e64ab9db04fedc89e910