mbox series

[v3,00/41] iio: simplify with regmap_set_bits(), regmap_clear_bits()

Message ID 20240617-review-v3-0-88d1338c4cca@baylibre.com (mailing list archive)
Headers show
Series iio: simplify with regmap_set_bits(), regmap_clear_bits() | expand

Message

Trevor Gamblin June 17, 2024, 1:49 p.m. UTC 
Simplify the way regmap is accessed in iio drivers.

Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Instead of using regmap_update_bits() and passing val = 0, use
regmap_clear_bits().

The series is marked as v3, but the previous two revisions were single
patches. There was also a resend of v1 due to not properly CCing the
mailing lists on the first attempt. Trailers were pulled in from those
where relevant.

Link to v2: https://lore.kernel.org/linux-iio/20240613133927.3851344-1-tgamblin@baylibre.com/
Link to v1: https://lore.kernel.org/linux-iio/20240611165214.4091591-1-tgamblin@baylibre.com/

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
---
Trevor Gamblin (41):
      iio: accel: fxls8962af-core: Make use of regmap_set_bits(), regmap_clear_bits()
      iio: accel: kxsd9: Make use of regmap_clear_bits()
      iio: accel: msa311: make use of regmap_clear_bits()
      iio: adc: ad4130: make use of regmap_clear_bits()
      iio: adc: axp20x_adc: make use of regmap_set_bits()
      iio: adc: axp288_adc: make use of regmap_set_bits()
      iio: adc: bcm_iproc_adc: make use of regmap_clear_bits()
      iio: adc: berlin2-adc: make use of regmap_clear_bits(), regmap_set_bits()
      iio: adc: cpcap-adc: make use of regmap_clear_bits(), regmap_set_bits()
      iio: adc: fsl-imx25-gcq: make use of regmap_clear_bits(), regmap_set_bits()
      iio: adc: ina2xx-adc: make use of regmap_clear_bits()
      iio: adc: intel_mrfld_adc: make use of regmap_clear_bits()
      iio: adc: meson_saradc: make use of regmap_clear_bits(), regmap_set_bits()
      iio: adc: mp2629_adc: make use of regmap_clear_bits(), regmap_set_bits()
      iio: adc: qcom-spmi-rradc: make use of regmap_clear_bits(), regmap_set_bits()
      iio: adc: rn5t618-adc: make use of regmap_set_bits()
      iio: adc: sc27xx_adc: make use of regmap_clear_bits(), regmap_set_bits()
      iio: adc: stm32-dfsdm-adc: make use of regmap_clear_bits(), regmap_set_bits()
      iio: dac: ltc2688: make use of regmap_set_bits()
      iio: dac: stm32-dac-core: make use of regmap_set_bits()
      iio: gyro: bmg160_core: make use of regmap_clear_bits()
      iio: gyro: mpu3050-core: make use of regmap_clear_bits(), regmap_set_bits()
      iio: health: afe4403: make use of regmap_clear_bits(), regmap_set_bits()
      iio: health: afe4404: make use of regmap_clear_bits(), regmap_set_bits()
      iio: health: max30100: make use of regmap_set_bits()
      iio: health: max30102: make use of regmap_set_bits()
      iio: imu: inv_icm42600: make use of regmap_clear_bits(), regmap_set_bits()
      iio: light: adux1020: make use of regmap_clear_bits(), regmap_set_bits()
      iio: light: iqs621-als: make use of regmap_clear_bits()
      iio: light: isl29018: make use of regmap_clear_bits()
      iio: light: st_uvis25_core: make use of regmap_clear_bits()
      iio: light: veml6030: make use of regmap_clear_bits()
      iio: magnetometer: ak8974: make use of regmap_set_bits()
      iio: magnetometer: mmc35240: make use of regmap_set_bits()
      iio: pressure: bmp280-core: make use of regmap_clear_bits()
      iio: proximity: sx9324: make use of regmap_set_bits()
      iio: proximity: sx9360: make use of regmap_set_bits()
      iio: proximity: sx9500: make use of regmap_clear_bits(), regmap_set_bits()
      iio: proximity: sx_common: make use of regmap_clear_bits(), regmap_set_bits()
      iio: temperature: mlx90632: make use of regmap_clear_bits()
      iio: trigger: stm32-timer-trigger: make use of regmap_clear_bits(), regmap_set_bits()

 drivers/iio/accel/fxls8962af-core.c                |  18 ++--
 drivers/iio/accel/kxsd9.c                          |   6 +-
 drivers/iio/accel/msa311.c                         |   8 +-
 drivers/iio/adc/ad4130.c                           |   4 +-
 drivers/iio/adc/axp20x_adc.c                       |   5 +-
 drivers/iio/adc/axp288_adc.c                       |   4 +-
 drivers/iio/adc/bcm_iproc_adc.c                    |   8 +-
 drivers/iio/adc/berlin2-adc.c                      |  24 +++--
 drivers/iio/adc/cpcap-adc.c                        |  46 ++++------
 drivers/iio/adc/fsl-imx25-gcq.c                    |  16 ++--
 drivers/iio/adc/ina2xx-adc.c                       |   3 +-
 drivers/iio/adc/intel_mrfld_adc.c                  |   4 +-
 drivers/iio/adc/meson_saradc.c                     | 101 +++++++++------------
 drivers/iio/adc/mp2629_adc.c                       |  19 ++--
 drivers/iio/adc/qcom-spmi-rradc.c                  |  50 +++++-----
 drivers/iio/adc/rn5t618-adc.c                      |   5 +-
 drivers/iio/adc/sc27xx_adc.c                       |  41 ++++-----
 drivers/iio/adc/stm32-dfsdm-adc.c                  |  29 +++---
 drivers/iio/dac/ltc2688.c                          |   5 +-
 drivers/iio/dac/stm32-dac-core.c                   |   5 +-
 drivers/iio/gyro/bmg160_core.c                     |   4 +-
 drivers/iio/gyro/mpu3050-core.c                    |  33 +++----
 drivers/iio/health/afe4403.c                       |   9 +-
 drivers/iio/health/afe4404.c                       |   9 +-
 drivers/iio/health/max30100.c                      |   5 +-
 drivers/iio/health/max30102.c                      |   5 +-
 drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c |  14 ++-
 drivers/iio/imu/inv_icm42600/inv_icm42600_core.c   |   9 +-
 drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c    |   4 +-
 drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c    |   4 +-
 drivers/iio/light/adux1020.c                       |  13 ++-
 drivers/iio/light/iqs621-als.c                     |   4 +-
 drivers/iio/light/isl29018.c                       |   6 +-
 drivers/iio/light/st_uvis25_core.c                 |   4 +-
 drivers/iio/light/veml6030.c                       |   4 +-
 drivers/iio/magnetometer/ak8974.c                  |  11 +--
 drivers/iio/magnetometer/mmc35240.c                |   8 +-
 drivers/iio/pressure/bmp280-core.c                 |   4 +-
 drivers/iio/proximity/sx9324.c                     |   5 +-
 drivers/iio/proximity/sx9360.c                     |   5 +-
 drivers/iio/proximity/sx9500.c                     |  12 +--
 drivers/iio/proximity/sx_common.c                  |   9 +-
 drivers/iio/temperature/mlx90632.c                 |   4 +-
 drivers/iio/trigger/stm32-timer-trigger.c          |  34 ++++---
 44 files changed, 273 insertions(+), 347 deletions(-)
---
base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
change-id: 20240614-review-7e60d159e75d

Best regards,

Comments

Nuno Sá June 17, 2024, 2:43 p.m. UTC | #1 
On Mon, 2024-06-17 at 09:49 -0400, Trevor Gamblin wrote:
> Instead of using regmap_update_bits() and passing the mask twice, use
> regmap_set_bits().
> 
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Uwe Kleine-König June 17, 2024, 3:17 p.m. UTC | #2 
Hello Trevor,

On Mon, Jun 17, 2024 at 09:49:40AM -0400, Trevor Gamblin wrote:
> Simplify the way regmap is accessed in iio drivers.
> 
> Instead of using regmap_update_bits() and passing the mask twice, use
> regmap_set_bits().
> 
> Instead of using regmap_update_bits() and passing val = 0, use
> regmap_clear_bits().
> 
> The series is marked as v3, but the previous two revisions were single
> patches. There was also a resend of v1 due to not properly CCing the
> mailing lists on the first attempt. Trailers were pulled in from those
> where relevant.
> 
> Link to v2: https://lore.kernel.org/linux-iio/20240613133927.3851344-1-tgamblin@baylibre.com/
> Link to v1: https://lore.kernel.org/linux-iio/20240611165214.4091591-1-tgamblin@baylibre.com/
> 
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>

Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Thanks
Uwe
Jonathan Cameron June 22, 2024, 6:07 p.m. UTC | #3 
On Mon, 17 Jun 2024 17:17:27 +0200
Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:

> Hello Trevor,
> 
> On Mon, Jun 17, 2024 at 09:49:40AM -0400, Trevor Gamblin wrote:
> > Simplify the way regmap is accessed in iio drivers.
> > 
> > Instead of using regmap_update_bits() and passing the mask twice, use
> > regmap_set_bits().
> > 
> > Instead of using regmap_update_bits() and passing val = 0, use
> > regmap_clear_bits().
> > 
> > The series is marked as v3, but the previous two revisions were single
> > patches. There was also a resend of v1 due to not properly CCing the
> > mailing lists on the first attempt. Trailers were pulled in from those
> > where relevant.
> > 
> > Link to v2: https://lore.kernel.org/linux-iio/20240613133927.3851344-1-tgamblin@baylibre.com/
> > Link to v1: https://lore.kernel.org/linux-iio/20240611165214.4091591-1-tgamblin@baylibre.com/
> > 
> > Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>  
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> 
Series applied with a few wrapping tweaks.

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to take a look + because I might rebase that tree after some fixes
make it upstream on which I have other dependencies and I don't like doing
that once it is in the public version of the togreg branch.

Thanks

Jonathan

> Thanks
> Uwe