mbox series

[0/3] arm64: dts: amlogic: Make mmc host controller interrupts level-sensitive

Message ID 8a99341b-8546-8f90-c9a5-087d927cac48@gmail.com (mailing list archive)
Headers show
Series arm64: dts: amlogic: Make mmc host controller interrupts level-sensitive | expand

Message

Heiner Kallweit Feb. 9, 2023, 8:09 p.m. UTC
The usage of edge-triggered interrupts lead to lost interrupts under load,
see [0]. This was confirmed to be fixed by using level-triggered
interrupts.
The report was about SDIO. However, as the host controller is the same
for SD and MMC, apply the change to all mmc controller instances.

[0] https://www.spinics.net/lists/linux-mmc/msg73991.html

This series replaces the prior "TEST"-annotated patch.

Heiner Kallweit (3):
  arm64: dts: meson-axg: Make mmc host controller interrupts
    level-sensitive
  arm64: dts: meson-g12-common: Make mmc host controller interrupts
    level-sensitive
  arm64: dts: meson-gx: Make mmc host controller interrupts
    level-sensitive

 arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 4 ++--
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 6 +++---
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi         | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

Comments

Neil Armstrong Feb. 10, 2023, 7:59 a.m. UTC | #1
On 09/02/2023 21:09, Heiner Kallweit wrote:
> The usage of edge-triggered interrupts lead to lost interrupts under load,
> see [0]. This was confirmed to be fixed by using level-triggered
> interrupts.
> The report was about SDIO. However, as the host controller is the same
> for SD and MMC, apply the change to all mmc controller instances.
> 
> [0] https://www.spinics.net/lists/linux-mmc/msg73991.html
> 
> This series replaces the prior "TEST"-annotated patch.
> 
> Heiner Kallweit (3):
>    arm64: dts: meson-axg: Make mmc host controller interrupts
>      level-sensitive
>    arm64: dts: meson-g12-common: Make mmc host controller interrupts
>      level-sensitive
>    arm64: dts: meson-gx: Make mmc host controller interrupts
>      level-sensitive
> 
>   arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 4 ++--
>   arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 6 +++---
>   arch/arm64/boot/dts/amlogic/meson-gx.dtsi         | 6 +++---
>   3 files changed, 8 insertions(+), 8 deletions(-)
> 

For whole serie:
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Neil Armstrong Feb. 10, 2023, 8:05 a.m. UTC | #2
Hi,

On Thu, 09 Feb 2023 21:09:25 +0100, Heiner Kallweit wrote:
> The usage of edge-triggered interrupts lead to lost interrupts under load,
> see [0]. This was confirmed to be fixed by using level-triggered
> interrupts.
> The report was about SDIO. However, as the host controller is the same
> for SD and MMC, apply the change to all mmc controller instances.
> 
> [0] https://www.spinics.net/lists/linux-mmc/msg73991.html
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.2/fixes)

[1/3] arm64: dts: meson-axg: Make mmc host controller interrupts level-sensitive
      https://git.kernel.org/amlogic/c/d182bcf300772d8b2e5f43e47fa0ebda2b767cc4
[2/3] arm64: dts: meson-g12-common: Make mmc host controller interrupts level-sensitive
      https://git.kernel.org/amlogic/c/ac8db4cceed218cca21c84f9d75ce88182d8b04f
[3/3] arm64: dts: meson-gx: Make mmc host controller interrupts level-sensitive
      https://git.kernel.org/amlogic/c/66e45351f7d6798751f98001d1fcd572024d87f0

These changes has been applied on the intermediate git tree [1].

The v6.2/fixes branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git