| Message ID | 1465546915-24229-4-git-send-email-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Hi Neil, Neil Armstrong <narmstrong@baylibre.com> writes: > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > index 832815d..8353621 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > @@ -167,6 +167,11 @@ > }; > }; > > + rng { > + compatible = "amlogic,meson-rng"; > + reg = <0x0 0xc8834000 0x0 0x4>; > + }; This should be under the periphs bus, with an offset of 0x0 instead of at the top level. See the for-next branch in the linux-amlogic tree[1] which has separate busses for periphs and hiu. Kevin [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git
On 06/14/2016 12:09 AM, Kevin Hilman wrote: > Hi Neil, > > Neil Armstrong <narmstrong@baylibre.com> writes: > >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> --- >> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> index 832815d..8353621 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> @@ -167,6 +167,11 @@ >> }; >> }; >> >> + rng { >> + compatible = "amlogic,meson-rng"; >> + reg = <0x0 0xc8834000 0x0 0x4>; >> + }; > > This should be under the periphs bus, with an offset of 0x0 instead of > at the top level. > > See the for-next branch in the linux-amlogic tree[1] which has separate > busses for periphs and hiu. Yes, It was introduced lately. Herbert, I'll repost this patch separately to arm-soc directly rebased on [1]. Thanks, Neil > Kevin > > [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git >
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index 832815d..8353621 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -167,6 +167,11 @@ }; }; + rng { + compatible = "amlogic,meson-rng"; + reg = <0x0 0xc8834000 0x0 0x4>; + }; + apb: apb@d0000000 { compatible = "simple-bus"; reg = <0x0 0xd0000000 0x0 0x200000>;
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++ 1 file changed, 5 insertions(+)