From patchwork Fri Jan 4 09:08:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corentin LABBE X-Patchwork-Id: 10748217 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 566B813AD for ; Fri, 4 Jan 2019 09:08:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 459242522B for ; Fri, 4 Jan 2019 09:08:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 39828260CD; Fri, 4 Jan 2019 09:08:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CD3912522B for ; Fri, 4 Jan 2019 09:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=VaB4CPUKl1sHS3Qf69XIpw3upCwGaVV+0a6icj+tV2w=; b=KiHEhoAaY7sx5H 2f1UVikHrtI2rx2hq6AGYXEXioevvQN4SD1Trz/ilBrwyc3rUVa7/xpNCukSCj7zrHjvLmN48CTER oeex6qNgnVeyIczt3w8u1LztkbsZuMvawiS05uH4zxI7pWoFPiOH/qYE1nHFjb2Z7rj7MpqDYog1R pF9DVzutiDHpHhkDzc5Fz8KVaNL6OtX7JbssGynbtZJ2L4Fa7XgSqAVV6pAN9cU9b7pv2g3Ki/ZUG 9o3F5AbhxWcsf4MGZC/vABirKBINh3xeKHwTQiOx+5FeFJsuUNo4E4CjOs0Vq5GRLsT/M5ysu8K+4 +p7IXfEHDxgCI6OYFcew==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gfLTI-0006La-06; Fri, 04 Jan 2019 09:08:52 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gfLTE-0006KR-6M for linux-amlogic@lists.infradead.org; Fri, 04 Jan 2019 09:08:50 +0000 Received: by mail-ed1-x542.google.com with SMTP id y56so31121871edd.11 for ; Fri, 04 Jan 2019 01:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rro8edKkspDsyyMgwTCAKGZP90S23S8Mpy2HGaolC+U=; b=v54FwiM+HJcwereFzem42m0Q+PUWYc4Qmcn7F742Drr8zKDSFetWKWaIS8mNrC4hCd JA0z4EdreTPJSu9d/t9SMUCZFh+XNi2hD0eQNk/fqiis9v3HXjE72gbSDszWY/cPlvIB w5vnVZHNn4AbopXwoWVJocDQVE76agb8d1OHVujkRpnhvcpWinQ0vR2/JhVDYy+UeeTv /jewQ02JTz0ueomyhWOqlOxdk6s4ztjabHbM1mluh5SEurEtF53+yBn/Hrke2iS1XERy E/8AvLWa7Cni+3LCcHr9KiqbFjPHOUK2W89RxNZ9ojWRERkGI9pMKE4REJVTe3fm/4ny /KEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rro8edKkspDsyyMgwTCAKGZP90S23S8Mpy2HGaolC+U=; b=aQLteLk3IQclogq5RuV8gy5LVuAEFO01RfOKZF4PkiK+mj8qx60jyR5cLgOvVB7gTU UXwlZI8lgQwc11Ldc1GiimaOGavQ/ZE1hkyVw2fN6ma9gdi33YMShfTTdDh6uw5e/cIv dd/kQd4bqYg8+8TnkaYeYvNrqmG+PM6Hy6nBE9UlC7O2KfjfoIAfHynRb67LV/qgUVaU 5hLbiwyZSz34uOnZj2A7h9yb4VNRYgS9OSE7s4wq/iUJv+gxeZ++Q/ZdNDhgJperPd6L y6pN5G/TiNp+uJfARmT1tEIqChNaOd6Rms09YFrUbikY1SW4mjIhcfEsCtrmbzmIuKDJ Tb6w== X-Gm-Message-State: AA+aEWaRv38u6K6fkxKB+n8ehMX8Bynu2T8k69pxOI3TYHeuAl8L6bU/ BIm2kFPbTBtKOD3H/FNEmpap7A== X-Google-Smtp-Source: AFSGD/UmoQlwTyOTfvgUi0Sh3vYYxytT7a1XJGMaK3OTpwLWlOcSUl+erzLqGAnERmwCnAgXqCMZTg== X-Received: by 2002:a17:906:f04:: with SMTP id z4-v6mr38740333eji.106.1546592924349; Fri, 04 Jan 2019 01:08:44 -0800 (PST) Received: from localhost.localdomain ([51.15.160.169]) by smtp.googlemail.com with ESMTPSA id o37sm24706587edc.32.2019.01.04.01.08.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Jan 2019 01:08:43 -0800 (PST) From: Corentin Labbe To: bhelgaas@google.com, khilman@baylibre.com, lorenzo.pieralisi@arm.com Subject: [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header Date: Fri, 4 Jan 2019 09:08:37 +0000 Message-Id: <1546592917-27846-1-git-send-email-clabbe@baylibre.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190104_010848_301604_3D690FFE X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, Corentin Labbe , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When building on x86, I got the following build failure: drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_assert_reset’: drivers/pci/controller/dwc/pci-meson.c:290:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration] gpiod_set_value_cansleep(mp->reset_gpio, 0); ^~~~~~~~~~~~~~~~~~~~~~~~ gpio_set_value_cansleep drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_probe’: drivers/pci/controller/dwc/pci-meson.c:540:19: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_gpio_free’? [-Werror=implicit-function-declaration] mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); ^~~~~~~~~~~~~~ devm_gpio_free drivers/pci/controller/dwc/pci-meson.c:540:48: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_LOW’? mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); ^~~~~~~~~~~~~ GPIOF_INIT_LOW This is due to the missing linux/gpio/consumer.h header Signed-off-by: Corentin Labbe --- drivers/pci/controller/dwc/pci-meson.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c index 241ebe0c4505..e35e9eaa50ee 100644 --- a/drivers/pci/controller/dwc/pci-meson.c +++ b/drivers/pci/controller/dwc/pci-meson.c @@ -8,6 +8,7 @@ #include #include +#include #include #include #include