| Message ID | 20160911134111.31141-6-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > From: Jerome Brunet <jbrunet@baylibre.com> > > Enable both gxbb USB controller and add a 5V regulator for the OTG port > VBUS > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> nit: subject should have "ARM64: dts:" prefix. > --- > arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 29 ++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi > index ce105fe..4493bce 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi > @@ -93,6 +93,18 @@ > compatible = "mmc-pwrseq-emmc"; > reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; > }; > + > + usb_vbus: regulator-usb0-vbus { nit: I like to use the signal name from the schematics for the node name (and for regulator-name below). In the schematics, that signal is named USB_PWR. > + compatible = "regulator-fixed"; > + > + regulator-name = "USB0_VBUS"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + > + gpio = <&gpio GPIODV_24 GPIO_ACTIVE_HIGH>; Please add a comment above this line with the schematic signal name: USB_PWR_EN. > + enable-active-high; > + }; > }; Kevin
Kevin Hilman <khilman@baylibre.com> writes: > Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > >> From: Jerome Brunet <jbrunet@baylibre.com> >> >> Enable both gxbb USB controller and add a 5V regulator for the OTG port >> VBUS >> >> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > > nit: subject should have "ARM64: dts:" prefix. > >> --- >> arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 29 ++++++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi >> index ce105fe..4493bce 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi >> @@ -93,6 +93,18 @@ >> compatible = "mmc-pwrseq-emmc"; >> reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; >> }; >> + >> + usb_vbus: regulator-usb0-vbus { > > nit: I like to use the signal name from the schematics for the node name > (and for regulator-name below). In the schematics, that signal is named > USB_PWR. > > >> + compatible = "regulator-fixed"; >> + >> + regulator-name = "USB0_VBUS"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + >> + gpio = <&gpio GPIODV_24 GPIO_ACTIVE_HIGH>; > > Please add a comment above this line with the schematic signal name: USB_PWR_EN. > For the record... after a chat with Martin on IRC, I just fixed these up myself locally, so... Applied, Kevin
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi index ce105fe..4493bce 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi @@ -93,6 +93,18 @@ compatible = "mmc-pwrseq-emmc"; reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; }; + + usb_vbus: regulator-usb0-vbus { + compatible = "regulator-fixed"; + + regulator-name = "USB0_VBUS"; + + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + + gpio = <&gpio GPIODV_24 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; }; /* This UART is brought out to the DB9 connector */ @@ -149,3 +161,20 @@ vmmc-supply = <&vcc_3v3>; vmmcq-sumpply = <&vddio_boot>; }; + +&usb0_phy { + status = "okay"; + phy-supply = <&usb_vbus>; +}; + +&usb1_phy { + status = "okay"; +}; + +&usb0 { + status = "okay"; +}; + +&usb1 { + status = "okay"; +};