| Message ID | 20161112131305.26088-4-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > When the USB PHY driver was introduced the reset framework did not > have support for triggering a reset pulse for shared resets. On GXBB > however there is only one reset line for both PHYs (meaning we have a > shared reset line). With the latest changes to the reset framework and > the corresponding updates to the phy-meson8b-usb2 driver we can now pass > the reset to the second PHY as well. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Applied. Thanks, Kevin
Hi Kevin, On Wed, Nov 16, 2016 at 10:35 PM, Kevin Hilman <khilman@baylibre.com> wrote: > Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > >> When the USB PHY driver was introduced the reset framework did not >> have support for triggering a reset pulse for shared resets. On GXBB >> however there is only one reset line for both PHYs (meaning we have a >> shared reset line). With the latest changes to the reset framework and >> the corresponding updates to the phy-meson8b-usb2 driver we can now pass >> the reset to the second PHY as well. >> >> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > Applied. Unfortunately I think I put crucial information only in the cover-letter's description: "the dts patch has a runtime-dependency on patch 1 and 2" So please feel free to keep or drop the patch as it is. In case you decide drop it I will re-send it for 4.11 (after all the 4.10 stuff is done).
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > Hi Kevin, > > On Wed, Nov 16, 2016 at 10:35 PM, Kevin Hilman <khilman@baylibre.com> wrote: >> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: >> >>> When the USB PHY driver was introduced the reset framework did not >>> have support for triggering a reset pulse for shared resets. On GXBB >>> however there is only one reset line for both PHYs (meaning we have a >>> shared reset line). With the latest changes to the reset framework and >>> the corresponding updates to the phy-meson8b-usb2 driver we can now pass >>> the reset to the second PHY as well. >>> >>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> >> Applied. > Unfortunately I think I put crucial information only in the > cover-letter's description: > "the dts patch has a runtime-dependency on patch 1 and 2" I saw that, but also see that both of those have been queued, so should land in v4.10 also. > So please feel free to keep or drop the patch as it is. In case you > decide drop it I will re-send it for 4.11 (after all the 4.10 stuff is > done). IMO, it's fine to keep it. That means there may be some versions of linux-next that have the problem where the reset will get asserted twice, but since that is affecting very few people (probably only you), I think it's OK, since it will be fine once v4.10-rc1 is released. If you don't want that, let me know and I'll drop it for now. Kevin
On Mon, Nov 21, 2016 at 9:15 PM, Kevin Hilman <khilman@baylibre.com> wrote: > Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > >> Hi Kevin, >> >> On Wed, Nov 16, 2016 at 10:35 PM, Kevin Hilman <khilman@baylibre.com> wrote: >>> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: >>> >>>> When the USB PHY driver was introduced the reset framework did not >>>> have support for triggering a reset pulse for shared resets. On GXBB >>>> however there is only one reset line for both PHYs (meaning we have a >>>> shared reset line). With the latest changes to the reset framework and >>>> the corresponding updates to the phy-meson8b-usb2 driver we can now pass >>>> the reset to the second PHY as well. >>>> >>>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >>> >>> Applied. >> Unfortunately I think I put crucial information only in the >> cover-letter's description: >> "the dts patch has a runtime-dependency on patch 1 and 2" > > I saw that, but also see that both of those have been queued, so should > land in v4.10 also. > >> So please feel free to keep or drop the patch as it is. In case you >> decide drop it I will re-send it for 4.11 (after all the 4.10 stuff is >> done). > > IMO, it's fine to keep it. That means there may be some versions of > linux-next that have the problem where the reset will get asserted > twice, but since that is affecting very few people (probably only you), > I think it's OK, since it will be fine once v4.10-rc1 is released. fine with me, just wanted to let you know (so you're aware of it in case someone runs into an issue with this) > If you don't want that, let me know and I'll drop it for now. let's keep it - this will mean that more users will test it :) Martin
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index 719bf50..a548663 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -87,6 +87,7 @@ compatible = "amlogic,meson-gxbb-usb2-phy"; #phy-cells = <0>; reg = <0x0 0xc0000020 0x0 0x20>; + resets = <&reset RESET_USB_OTG>; clocks = <&clkc CLKID_USB>, <&clkc CLKID_USB1>; clock-names = "usb_general", "usb"; status = "disabled";
When the USB PHY driver was introduced the reset framework did not have support for triggering a reset pulse for shared resets. On GXBB however there is only one reset line for both PHYs (meaning we have a shared reset line). With the latest changes to the reset framework and the corresponding updates to the phy-meson8b-usb2 driver we can now pass the reset to the second PHY as well. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 1 + 1 file changed, 1 insertion(+)