| Message ID | 20161206140817.11708-1-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Neil Armstrong <narmstrong@baylibre.com> writes: > The pinctrl_gpio_request is called with the "full" gpio number, already > containing the base, then meson_pmx_request_gpio is then called with the > final pin number. > Remove the base addition when calling meson_pmx_disable_other_groups. > > Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs") > CC: Beniamino Galvani <b.galvani@gmail.com> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Acked-by: Kevin Hilman <khilman@baylibre.com>
On Tue, Dec 06, 2016 at 03:08:16PM +0100, Neil Armstrong wrote: > The pinctrl_gpio_request is called with the "full" gpio number, already > containing the base, then meson_pmx_request_gpio is then called with the > final pin number. > Remove the base addition when calling meson_pmx_disable_other_groups. > > Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs") > CC: Beniamino Galvani <b.galvani@gmail.com> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Acked-by: Beniamino Galvani <b.galvani@gmail.com>
On Tue, Dec 6, 2016 at 3:08 PM, Neil Armstrong <narmstrong@baylibre.com> wrote: > The pinctrl_gpio_request is called with the "full" gpio number, already > containing the base, then meson_pmx_request_gpio is then called with the > final pin number. > Remove the base addition when calling meson_pmx_disable_other_groups. > > Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs") > CC: Beniamino Galvani <b.galvani@gmail.com> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Patch applied for fixes. Sorry for the delay, merge window appeared inbetween. Yours, Linus Walleij
diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c index a579126..620c231a 100644 --- a/drivers/pinctrl/meson/pinctrl-meson.c +++ b/drivers/pinctrl/meson/pinctrl-meson.c @@ -212,7 +212,7 @@ static int meson_pmx_request_gpio(struct pinctrl_dev *pcdev, { struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev); - meson_pmx_disable_other_groups(pc, range->pin_base + offset, -1); + meson_pmx_disable_other_groups(pc, offset, -1); return 0; }
The pinctrl_gpio_request is called with the "full" gpio number, already containing the base, then meson_pmx_request_gpio is then called with the final pin number. Remove the base addition when calling meson_pmx_disable_other_groups. Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs") CC: Beniamino Galvani <b.galvani@gmail.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- drivers/pinctrl/meson/pinctrl-meson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)